Create a PR comment with docs preview link #1788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Once the build has completed, you can preview any updated documentation at this URL: https://fluxml.ai/Flux.jl/previews/previews/PR1788/ in ~20 minutes |
|
The problem is, AIUI, that docs previews are only generated for PRs opened by members (with the right set of permissions). So we couldn't tack this onto any old PR. |
|
Yeah, it would be nice if it let us do that, the current version in this PR only runs when the PR is made from a branch, not from forks. So it will work as is. |
logankilpatrick
commented
Nov 26, 2021
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Create PR comment | ||
| if: github.event_name == 'pull_request' && github.repository == github.event.pull_request.head.repo.full_name # if this is a pull request build AND the pull request is NOT made from a fork |
There was a problem hiding this comment.
That's what I get for not scrolling to the end, thanks!
ToucheSir
approved these changes
Nov 26, 2021
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like per @ToucheSir 's comment here: #1784, there is already a documentation preview workflow setup. This simply adds a comment to the PR with a link like we do on the JuliaLang.org website repo.