[TASK] Hide package label in page layout selector if no page layouts are provided #260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| require $emConfigFile; | ||
| $groupTitle = $EM_CONF['']['title']; | ||
| } | ||
| if (!empty($group)) { |
There was a problem hiding this comment.
empty($group) === FALSE please ;)
There was a problem hiding this comment.
Ooops! CGL :) But shouldn't that be FALSE === empty($group)?
There was a problem hiding this comment.
Of course, correct! I'm doing code reviews in four different CGLs this week, sorry about the confusion.
|
Sorry. Using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch makes
PageLayoutSelector->renderOptions()return an empty string and thus does not render the package label if the provider extension does not provide any page layouts. See FluidTYPO3/flux#839 (comment)