This pull request addresses an Azure deployment issue related to the … #3364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…DATABASE_SSL parameter. The changes allow for more flexible SSL configurations to be passed as a JSON string through the DATABASE_SSL environment variable.
Changes made:
Modified the getDatabaseSSLFromEnv function in packages/server/src/DataSource.ts to parse the DATABASE_SSL environment variable as a JSON string.
Added support for complex SSL configurations, including the ability to specify a 'ca' certificate file path.
Maintained backwards compatibility with the existing DATABASE_SSL_KEY_BASE64 and boolean DATABASE_SSL configurations.
To use the new functionality:
Set the DATABASE_SSL environment variable to a JSON string containing the desired SSL configuration.
For example: {rejectUnauthorized: true, ca: /path/to/certificate.pem}
This change allows for more granular control over SSL settings when deploying to Azure, while maintaining compatibility with existing configurations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…DATABASE_SSL parameter. The changes allow for more flexible SSL configurations to be passed as a JSON string through the DATABASE_SSL environment variable.
Changes made:
Modified the getDatabaseSSLFromEnv function in packages/server/src/DataSource.ts to parse the DATABASE_SSL environment variable as a JSON string. Added support for complex SSL configurations, including the ability to specify a 'ca' certificate file path. Maintained backwards compatibility with the existing DATABASE_SSL_KEY_BASE64 and boolean DATABASE_SSL configurations. To use the new functionality:
Set the DATABASE_SSL environment variable to a JSON string containing the desired SSL configuration. For example: {rejectUnauthorized: true, ca: /path/to/certificate.pem} This change allows for more granular control over SSL settings when deploying to Azure, while maintaining compatibility with existing configurations.