[extensions] Improve IAE message thrown by FormFieldRegistry

Flowdalic · Jan 18, 2024 · e504bc2 · e504bc2
1 parent 8133505
commit e504bc2
Showing 1 changed file with 7 additions and 1 deletion.
diff --git a/smack-extensions/src/main/java/org/jivesoftware/smackx/formtypes/FormFieldRegistry.java b/smack-extensions/src/main/java/org/jivesoftware/smackx/formtypes/FormFieldRegistry.java
@@ -94,7 +94,13 @@ public static void register(String formType, String fieldName, FormField.Type fi
             } else {
                 previousType = fieldNameToType.get(fieldName);
                 if (previousType != null && previousType != fieldType) {
-                    throw new IllegalArgumentException();
+                    String message = "The field '" + fieldName + "' from form type '" + formType
+                                    + "' was already registered with field type '" + previousType
+                                    + "' while it is now seen with type '" + fieldType
+                                    + "'. Form field types have to be unambigiously."
+                                    + " XMPP uses a registry for form field tpes, scoped by the form type."
+                                    + " You may find the correct value at https://xmpp.org/registrar/formtypes.html";
+                    throw new IllegalArgumentException(message);
                 }
             }
             previousType = fieldNameToType.put(fieldName, fieldType);