Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure all pub/sub MQTT operations use QoS 2 #99

Merged
merged 4 commits into from
Sep 2, 2024
Merged

Ensure all pub/sub MQTT operations use QoS 2 #99

merged 4 commits into from
Sep 2, 2024

Conversation

Steve-Mcl
Copy link
Contributor

closes #98

Description

  • Defaults to using QoS 2
  • Adds tests to detect regression

Tests

  project-link node
    Nodes
      ✔ project link in should subscribe using QoS 2
      ✔ project link call should publish and subscribe using QoS 2
      ✔ project link out should publish using QoS 2

Related Issue(s)

#98

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Includes a DB migration? -> add the area:migration label

@Steve-Mcl Steve-Mcl requested a review from knolleary September 2, 2024 13:19
@knolleary knolleary merged commit 330e6e1 into main Sep 2, 2024
6 checks passed
@knolleary knolleary deleted the 98-qos-2 branch September 2, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ensure QoS 2 on all publish and subscripe options object
2 participants