Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Project Nodes multiple MQTT connections issue #66

Merged
merged 1 commit into from
Mar 19, 2024

Conversation

Steve-Mcl
Copy link
Contributor

closes #62

Description

  1. Adds a containment function to verify there is only ever 1 connection
  2. unconditionally calls end with the force parameter set true after a normal end (regardless of success)

these 2 containment measures have proved to successfully maintain a single connection regardless of my attempts to break it.

Related Issue(s)

#62

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Backport needed? -> add the backport label
  • Includes a DB migration? -> add the area:migration label

@Steve-Mcl Steve-Mcl requested a review from hardillb March 18, 2024 16:37
@Steve-Mcl Steve-Mcl merged commit 6d4bb3c into main Mar 19, 2024
4 checks passed
@Steve-Mcl Steve-Mcl deleted the 62-contain-multiple-connections branch March 19, 2024 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Project Nodes can get into a state of creating multiple MQTT connections
2 participants