Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for communicating with app assigned devices #55

Merged
merged 4 commits into from
Nov 22, 2023

Conversation

Steve-Mcl
Copy link
Contributor

Description

Adds support for communicating with app assigned devices
Updates node editor labels
Update docs to mention devices

Related Issue(s)

FlowFuse/flowfuse#3018

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Backport needed? -> add the backport label
  • Includes a DB migration? -> add the area:migration label

FlowFuse 1.14+, update node editor labels, update docs
@Steve-Mcl Steve-Mcl requested a review from knolleary November 21, 2023 22:01
@Steve-Mcl
Copy link
Contributor Author

@knolleary I have updated this to use app:app-id in the topics.

NOTE: I acknowledge no tests are written for this PR. I will follow up with an issue to get the first round of tests implemented that cover these changes.

@Steve-Mcl Steve-Mcl mentioned this pull request Nov 22, 2023
@Steve-Mcl
Copy link
Contributor Author

@knolleary changes pushed for using dev: topic prefix

@knolleary knolleary merged commit 929dc4c into main Nov 22, 2023
4 checks passed
@knolleary knolleary deleted the 3018-support-app-assigned-devices branch November 22, 2023 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Project Nodes unavailable on a Device assigned to an Application
2 participants