Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nr-launcher was not catching console.error output #269

Merged
merged 1 commit into from
Jul 26, 2024
Merged

nr-launcher was not catching console.error output #269

merged 1 commit into from
Jul 26, 2024

Conversation

hardillb
Copy link
Contributor

Description

While testing #267 I noticed that the nr-launcher was not grabbing stderr from the NR process.

This ensures that stderr gets pushed to the forge app as part of the log stream

Related Issue(s)

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Includes a DB migration? -> add the area:migration label

@hardillb hardillb requested a review from knolleary July 26, 2024 10:20
@hardillb hardillb self-assigned this Jul 26, 2024
@knolleary knolleary merged commit d92228c into main Jul 26, 2024
5 checks passed
@knolleary knolleary deleted the log-stderr branch July 26, 2024 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knolleary knolleary knolleary approved these changes

Assignees

@hardillb hardillb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hardillb @knolleary