Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: Allow publish only when changes are pushed to main branch #64

Merged
merged 1 commit into from
Aug 14, 2023
Merged

FIX: Allow publish only when changes are pushed to main branch #64

merged 1 commit into from
Aug 14, 2023

Conversation

ppawlowski
Copy link
Contributor

@ppawlowski ppawlowski commented Aug 14, 2023 •
edited
Loading

Description

Temporarily - run publish package job only when changes are pushed to main branch.
Approach with github.event.pull_request.merged caused pipeline execution against merged branch, not main one.

Related Issue(s)

Checklist

  • have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on flowforge/helm to update ConfigMap Template
    • Issue/PR raised on flowforge/CloudProject to update values for Staging/Production

Labels

  • Backport needed? -> add the backport label
  • Includes a DB migration? -> add the area:migration label

@ppawlowski ppawlowski requested a review from hardillb August 14, 2023 16:16
@hardillb hardillb merged commit e99f209 into main Aug 14, 2023
@hardillb hardillb deleted the fix-publish-on-push-to-main branch August 14, 2023 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hardillb hardillb hardillb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ppawlowski @hardillb