Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure userDir/storage is created #135

Merged
merged 3 commits into from
Jun 21, 2024
Merged

Ensure userDir/storage is created #135

merged 3 commits into from
Jun 21, 2024

Conversation

hardillb
Copy link
Contributor

@hardillb hardillb commented Jun 17, 2024 •
edited
Loading

part of FlowFuse/flowfuse#3056

Description

This is needed for the Persistent Storage changes.

Must be merged before FlowFuse/nr-launcher#250

This is so that nr-launcher

Related Issue(s)

FlowFuse/flowfuse#3056

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Includes a DB migration? -> add the area:migration label

@hardillb
Ensure userDir/storage is created
e5d4c92 
This is needed for the Persistent Storage changes
@hardillb hardillb self-assigned this Jun 17, 2024
@hardillb hardillb mentioned this pull request Jun 17, 2024
Merged
13 tasks
@hardillb hardillb requested a review from knolleary June 17, 2024 09:48
knolleary
knolleary requested changes Jun 20, 2024
View reviewed changes
Copy link
Member

@knolleary knolleary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Misplaced brackets

localfs.js Outdated Show resolved Hide resolved
localfs.js Outdated Show resolved Hide resolved
@hardillb hardillb requested a review from knolleary June 20, 2024 14:18
@knolleary knolleary merged commit 0b77ab0 into main Jun 21, 2024
3 checks passed
@knolleary knolleary deleted the persistent-storage branch June 21, 2024 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knolleary knolleary knolleary approved these changes

Assignees

@hardillb hardillb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hardillb @knolleary