Skip to content

Commit

Permalink
Ensure Scylla driver is used for scylla-hadoop
Browse files Browse the repository at this point in the history
I don't know why this exclusion is necessary because
`cassandra-driver-core` is only an optional dependency of
`janusgraph-cql` and should therefore not be included in the classpath
of `janusgraph-scylla` any way, but it looks like that is not the case.

At least we got failing Scylla Hadoop tests after trying to update the
Scylla driver to 3.11.5. They fail with a `NoSuchMethodError` on
`ResultSet.one()` which was removed in the Scylla driver.

@Bouncheck mentioned that this error should only be possible if we
actually have another version of the driver on our classpath which let
to this (hopefully) fix.

Signed-off-by: Florian Hockmann <[email protected]>
  • Loading branch information
FlorianHockmann committed Aug 1, 2024
1 parent ff323da commit 5f00e33
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions janusgraph-scylla/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,10 @@
<groupId>com.datastax.oss</groupId>
<artifactId>java-driver-query-builder</artifactId>
</exclusion>
<exclusion>
<groupId>com.datastax.cassandra</groupId>
<artifactId>cassandra-driver-core</artifactId>
</exclusion>
</exclusions>
</dependency>

Expand Down

1 comment on commit 5f00e33

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: 5f00e33 Previous: 232a3ca Ratio
org.janusgraph.JanusGraphSpeedBenchmark.basicAddAndDelete 12882.440922127775 ms/op 12956.787543346796 ms/op 0.99
org.janusgraph.GraphCentricQueryBenchmark.getVertices 905.3886182637102 ms/op 902.1703069801889 ms/op 1.00
org.janusgraph.MgmtOlapJobBenchmark.runClearIndex 216.20551551014492 ms/op 216.24256983913043 ms/op 1.00
org.janusgraph.MgmtOlapJobBenchmark.runReindex 344.89862059961536 ms/op 334.9591941392857 ms/op 1.03
org.janusgraph.JanusGraphSpeedBenchmark.basicCount 211.66081952166306 ms/op 209.00021040347767 ms/op 1.01
org.janusgraph.CQLMultiQueryMultiSlicesBenchmark.getValuesAllPropertiesWithAllMultiQuerySlicesUnderMaxRequestsPerConnection 4818.459405162898 ms/op 5037.0925838105195 ms/op 0.96
org.janusgraph.CQLMultiQueryBenchmark.getElementsWithUsingEmitRepeatSteps 16629.15422353863 ms/op 16657.718093551666 ms/op 1.00
org.janusgraph.CQLMultiQueryMultiSlicesBenchmark.getValuesMultiplePropertiesWithSmallBatch 19532.950324311514 ms/op 21065.000455233134 ms/op 0.93
org.janusgraph.CQLMultiQueryMultiSlicesBenchmark.vertexCentricPropertiesFetching 56254.793527300004 ms/op 58456.6589335 ms/op 0.96
org.janusgraph.CQLMultiQueryDropBenchmark.dropVertices 1544.1697414929463 ms/op 1562.8454594797659 ms/op 0.99
org.janusgraph.CQLMultiQueryBenchmark.getAllElementsTraversedFromOuterVertex 8094.758052314057 ms/op 7957.58089929328 ms/op 1.02
org.janusgraph.CQLMultiQueryBenchmark.getVerticesWithDoubleUnion 386.2294761984996 ms/op 378.7484547022495 ms/op 1.02
org.janusgraph.CQLMultiQueryMultiSlicesBenchmark.getValuesAllPropertiesWithUnlimitedBatch 4212.198763568307 ms/op 4337.537304374108 ms/op 0.97
org.janusgraph.CQLMultiQueryBenchmark.getNames 8287.14873015512 ms/op 8008.8382583107905 ms/op 1.03
org.janusgraph.CQLMultiQueryMultiSlicesBenchmark.getValuesThreePropertiesWithAllMultiQuerySlicesUnderMaxRequestsPerConnection 5703.964245191555 ms/op 6210.610506507202 ms/op 0.92
org.janusgraph.CQLMultiQueryBenchmark.getLabels 7019.312043938019 ms/op 7088.398645351861 ms/op 0.99
org.janusgraph.CQLMultiQueryBenchmark.getVerticesFilteredByAndStep 421.5336921542358 ms/op 421.43212310684606 ms/op 1.00
org.janusgraph.CQLMultiQueryBenchmark.getVerticesFromMultiNestedRepeatStepStartingFromSingleVertex 12049.85838935817 ms/op 11822.11288646013 ms/op 1.02
org.janusgraph.CQLMultiQueryBenchmark.getVerticesWithCoalesceUsage 363.6792418260749 ms/op 363.2128115602137 ms/op 1.00
org.janusgraph.CQLMultiQueryMultiSlicesBenchmark.getValuesMultiplePropertiesWithAllMultiQuerySlicesUnderMaxRequestsPerConnection 15140.04796207105 ms/op 15104.220894219523 ms/op 1.00
org.janusgraph.CQLMultiQueryBenchmark.getIdToOutVerticesProjection 247.8207640796067 ms/op 245.19139725925493 ms/op 1.01
org.janusgraph.CQLMultiQueryMultiSlicesBenchmark.getValuesMultiplePropertiesWithUnlimitedBatch 14674.180635047776 ms/op 15177.351274470668 ms/op 0.97
org.janusgraph.CQLMultiQueryBenchmark.getNeighborNames 8036.689384365836 ms/op 7978.568882459052 ms/op 1.01
org.janusgraph.CQLMultiQueryBenchmark.getElementsWithUsingRepeatUntilSteps 8982.4757617982 ms/op 8827.772842934128 ms/op 1.02
org.janusgraph.CQLMultiQueryBenchmark.getAdjacentVerticesLocalCounts 8437.223584256195 ms/op 8352.248955390452 ms/op 1.01

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.