split i2c_read into read and write_read #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ill give it a look today, thanks for the PR |
|
I tried this on my async fork as it wasnt working with embassy-stm32 and with work applied its now working 🎉 |
|
This fixes the package for me too! I was going crazy with this not working. This is on a Raspberry Pi 5. Please, merge this fix. And make a bug fix version release of the package @FloppyDisck . |
FloppyDisck
approved these changes
Jun 16, 2024
|
Can you make it so the commits don't have to be signed? |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using new esp-idf i2c interface, it is an error to use
write_readwith an empty send buffer. I split the read into singlereadandread_write.I couldn't confirm if it works as it should after these changes.