Make library no_std compatible #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use embedded_hal::blocking::delay::DelayMs instead of std::thread::sleep * Make thiserror dependency an optional feature
|
Awesome, looks good so far after reviewing the code, thank you! Im going to go ahead and bypass the checks since the only clippy issues found are pertaining to tests that I wrote, oops |
|
You should now be able to use the new library with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey FloppyDisck,
I made some changes to your library to make it no_std compatible.
embedded_hal::blocking::delay::DelayMsinstead ofstd::thread::sleepWhat do you think?