Add compilation errors & SAT GitHub annotations (openhab#2543)

Signed-off-by: Yannick Schaus <[email protected]>
Flole998 · Nov 13, 2021 · d4f62ed · d4f62ed
1 parent 917e268
commit d4f62ed
Show file tree

Hide file tree

Showing 7 changed files with 40 additions and 16 deletions.
diff --git a/.github/openhab-compile-problems.json b/.github/openhab-compile-problems.json
@@ -0,0 +1,21 @@
+{
+  "problemMatcher": [
+    {
+      "owner": "openhab-compile-problems",
+      "severity": "error",
+      "pattern": [
+        {
+          "regexp": "Failed to execute goal.*Compilation failure"
+        },
+        {
+          "regexp": "^\\[ERROR\\] (.+\\.java):\\[(.+),(.+)\\] (.*)$",
+          "file": 1,
+          "line": 2,
+          "col": 3,
+          "message": 4,
+          "loop": true
+        }
+      ]
+    }
+  ]
+}
diff --git a/.github/workflows/ci-build.yml b/.github/workflows/ci-build.yml
@@ -54,6 +54,11 @@ jobs:
         with:
           maven-version: ${{ matrix.maven }}
 
+      - name: Register Problem Matchers
+        id: problem_matchers
+        run: |
+          echo "::add-matcher::.github/openhab-compile-problems.json"
+
       - name: Build
         id: build
         run: './.github/scripts/maven-build'
@@ -77,3 +82,11 @@ jobs:
         with:
           name: sat-summary-report
           path: target/summary_report.html
+
+      - name: Report SAT Errors as Annotations
+        uses: ghys/checkstyle-github-action@main
+        if: ${{ always() && ((steps.build.outcome == 'success') || (steps.build.outcome == 'failure')) }}
+        with:
+          title: CheckStyle Violations
+          path: '**/checkstyle-result.xml'
+          mode: inline
diff --git a/...ava/org/openhab/core/io/transport/modbus/exception/ModbusSlaveErrorResponseException.java b/...ava/org/openhab/core/io/transport/modbus/exception/ModbusSlaveErrorResponseException.java
@@ -28,10 +28,10 @@
 @NonNullByDefault
 public abstract class ModbusSlaveErrorResponseException extends ModbusTransportException {
 
-    private static final Map<Integer, KnownExceptionCode> exceptionCodesIndex = new HashMap<>(10);
+    private static final Map<Integer, KnownExceptionCode> EXCEPTION_CODES_INDEX = new HashMap<>(10);
     static {
         for (KnownExceptionCode code : KnownExceptionCode.values()) {
-            exceptionCodesIndex.put(code.exceptionCode, code);
+            EXCEPTION_CODES_INDEX.put(code.exceptionCode, code);
         }
     }
 
@@ -64,7 +64,7 @@ public int getExceptionCode() {
         }
 
         public static Optional<KnownExceptionCode> tryFromExceptionCode(int exceptionCode) {
-            return Optional.ofNullable(exceptionCodesIndex.get(exceptionCode));
+            return Optional.ofNullable(EXCEPTION_CODES_INDEX.get(exceptionCode));
         }
     }
 

diff --git a/bundles/org.openhab.core/src/main/java/org/openhab/core/cache/ByteArrayFileCache.java b/bundles/org.openhab.core/src/main/java/org/openhab/core/cache/ByteArrayFileCache.java
@@ -65,8 +65,9 @@ public ByteArrayFileCache(String servicePID) {
      *            disable this functionality.
      */
     public ByteArrayFileCache(String servicePID, Duration expiry) {
-        // TODO track and limit folder size
-        // TODO support user specific folder
+        // possible to-dos:
+        // - track and limit folder size
+        // - support user specific folder
         cacheFolder = new File(new File(OpenHAB.getUserDataFolder(), CACHE_FOLDER_NAME), servicePID);
         if (!cacheFolder.exists()) {
             logger.debug("Creating cache folder '{}'", cacheFolder.getAbsolutePath());

diff --git a/bundles/org.openhab.core/src/main/java/org/openhab/core/library/types/DecimalType.java b/bundles/org.openhab.core/src/main/java/org/openhab/core/library/types/DecimalType.java
@@ -61,7 +61,6 @@ public DecimalType(double value) {
      * The English locale is used to determine (decimal/grouping) separator characters.
      *
      * @param value the non null value representing a number
-     *
      * @throws NumberFormatException when the number could not be parsed to a {@link BigDecimal}
      */
     public DecimalType(String value) {
@@ -73,7 +72,6 @@ public DecimalType(String value) {
      *
      * @param value the non null value representing a number
      * @param locale the locale used to determine (decimal/grouping) separator characters
-     *
      * @throws NumberFormatException when the number could not be parsed to a {@link BigDecimal}
      */
     public DecimalType(String value, Locale locale) {
@@ -102,7 +100,6 @@ public String toFullString() {
      *
      * @param value the non null value representing a number
      * @return a new {@link DecimalType}
-     *
      * @throws NumberFormatException when the number could not be parsed to a {@link BigDecimal}
      */
     public static DecimalType valueOf(String value) {

diff --git a/bundles/org.openhab.core/src/main/java/org/openhab/core/library/types/PercentType.java b/bundles/org.openhab.core/src/main/java/org/openhab/core/library/types/PercentType.java
@@ -45,7 +45,6 @@ public PercentType() {
      * Creates a new {@link PercentType} with the given value.
      *
      * @param value the value representing a percentage
-     *
      * @throws IllegalArgumentException when the value is not between 0 and 100
      */
     public PercentType(int value) {
@@ -58,7 +57,6 @@ public PercentType(int value) {
      * The English locale is used to determine (decimal/grouping) separator characters.
      *
      * @param value the non null value representing a percentage
-     *
      * @throws NumberFormatException when the number could not be parsed to a {@link BigDecimal}
      * @throws IllegalArgumentException when the value is not between 0 and 100
      */
@@ -71,7 +69,6 @@ public PercentType(String value) {
      *
      * @param value the non null value representing a percentage
      * @param locale the locale used to determine (decimal/grouping) separator characters
-     *
      * @throws NumberFormatException when the number could not be parsed to a {@link BigDecimal}
      * @throws IllegalArgumentException when the value is not between 0 and 100
      */
@@ -84,7 +81,6 @@ public PercentType(String value, Locale locale) {
      * Creates a new {@link PercentType} with the given value.
      *
      * @param value the value representing a percentage.
-     *
      * @throws IllegalArgumentException when the value is not between 0 and 100
      */
     public PercentType(BigDecimal value) {
@@ -103,7 +99,6 @@ private void validateValue(BigDecimal value) {
      *
      * @param value the non null value representing a percentage
      * @return new {@link PercentType}
-     *
      * @throws NumberFormatException when the number could not be parsed to a {@link BigDecimal}
      * @throws IllegalArgumentException when the value is not between 0 and 100
      */

diff --git a/bundles/org.openhab.core/src/main/java/org/openhab/core/library/types/QuantityType.java b/bundles/org.openhab.core/src/main/java/org/openhab/core/library/types/QuantityType.java
@@ -99,7 +99,6 @@ public QuantityType() {
      * The English locale is used to determine (decimal/grouping) separator characters.
      *
      * @param value the non null value representing a quantity with an optional unit.
-     *
      * @throws NumberFormatException when a quantity without a unit could not be parsed
      * @throws IllegalArgumentException when a quantity with a unit could not be parsed
      */
@@ -113,7 +112,6 @@ public QuantityType(String value) {
      *
      * @param value the non null value representing a quantity with an optional unit.
      * @param locale the locale used to determine (decimal/grouping) separator characters.
-     *
      * @throws NumberFormatException when a quantity without a unit could not be parsed
      * @throws IllegalArgumentException when a quantity with a unit could not be parsed
      */
@@ -201,7 +199,6 @@ public String toString() {
      *
      * @param value the non null value representing a quantity with an optional unit
      * @return a new {@link QuantityType}
-     *
      * @throws NumberFormatException when a quantity without a unit could not be parsed
      * @throws IllegalArgumentException when a quantity with a unit could not be parsed
      */