Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Persistent Dispatch Queue #97

Merged
merged 8 commits into from
May 31, 2023

Conversation

EPNW-Eric
Copy link
Contributor

Currently, if the app is terminated and there are still undispatched actions, they will be lost.

To circumvent this, I added an implementation that allows the dispatch queue to be persistent and store actions in the LocalStorage until they are dispatched.

I also added a filter mechanism that allows the user to select which actions are still entitled to dispatching after the next app launch. The default filter only retains actions that are not older than a day, since older actions would need a tokenAuth (see Tracking HTTP API section cdt).

Copy link
Member

@TesteurManiak TesteurManiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As always, a big thank you for your contribution. I just have some small remarks on the code.

lib/src/dispatch_settings.dart Outdated Show resolved Hide resolved
lib/src/dispatch_settings.dart Show resolved Hide resolved
lib/src/dispatch_settings.dart Show resolved Hide resolved
lib/src/dispatch_settings.dart Show resolved Hide resolved
lib/src/persistent_queue.dart Outdated Show resolved Hide resolved
lib/src/persistent_queue.dart Outdated Show resolved Hide resolved
lib/src/persistent_queue.dart Show resolved Hide resolved
@TesteurManiak TesteurManiak self-assigned this May 30, 2023
@TesteurManiak TesteurManiak added the enhancement New feature or request label May 30, 2023
@MeixDev MeixDev added documentation Improvements or additions to documentation and removed documentation Improvements or additions to documentation labels May 31, 2023
@TesteurManiak TesteurManiak merged commit 1affc27 into Floating-Dartists:dev May 31, 2023
@EPNW-Eric EPNW-Eric deleted the persistent_dispatch_queue branch May 31, 2023 16:15
@EPNW-Eric EPNW-Eric mentioned this pull request May 31, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants