Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add dimensions tracking #17

Merged
merged 2 commits into from
Sep 7, 2022

Conversation

petcupaula
Copy link
Contributor

What

Implementation considerations

  • Basically the dimensions are key value pairs, so in the proposed implementation just adding them to the query params.
  • There are two ways to add the dimensions, either when an event is tracked (and dimensions is an optional argument) via the updated trackEvent, or via a new function trackDimensions

Documentation

@TesteurManiak TesteurManiak added the enhancement New feature or request label Sep 7, 2022
@TesteurManiak TesteurManiak merged commit e002221 into Floating-Dartists:main Sep 7, 2022
@TesteurManiak
Copy link
Member

TesteurManiak commented Sep 7, 2022

Everything seems good to me, thank you for your contribution @petcupaula
Your change will be part of the release 1.4.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants