Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Change siteId to a String type #129

Closed
jainhitesh9998 opened this issue Dec 27, 2023 · 4 comments
Closed

Feat: Change siteId to a String type #129

jainhitesh9998 opened this issue Dec 27, 2023 · 4 comments
Labels
enhancement New feature or request good first issue Good for newcomers priority-low Low priority issues or PR

Comments

@jainhitesh9998
Copy link
Contributor

Describe the bug
A clear and concise description of what the bug is.

Configuring Matomo-ProtectTrackID enables us to use hash instead of int as part of site-id.
Changing the datatype of siteid from in to String has no affect on the functionality, but improves the compatibility with the ProtectTrackID library as the site id generated then are string.

To Reproduce
Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

Smartphone (please complete the following information):

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 22]

Additional context
Add any other context about the problem here.

@jainhitesh9998
Copy link
Contributor Author

we have tested it with our setup, can raise a PR for the same.

@TesteurManiak TesteurManiak added enhancement New feature or request good first issue Good for newcomers priority-low Low priority issues or PR labels Dec 27, 2023
@TesteurManiak
Copy link
Member

Sure! I don't see any problem with changing MatomoTracker.siteId to a String type. You can open a PR for review, otherwise I'll make the changes after my vacations.

@TesteurManiak TesteurManiak changed the title Support for joubertredrat/Matomo-ProtectTrackID Feat: Change siteId to a String type Dec 27, 2023
jainhitesh9998 added a commit to jainhitesh9998/matomo-tracker that referenced this issue Dec 28, 2023
Changed type of siteId to String
TesteurManiak added a commit that referenced this issue Dec 29, 2023
@ken717w
Copy link

ken717w commented Sep 10, 2024

Just upgraded from 4.x to 5.0 and found this breaking change. This should be mentioned in the upgrade guide.

@TesteurManiak
Copy link
Member

@ken717w Documentation has been updated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers priority-low Low priority issues or PR
Projects
None yet
Development

No branches or pull requests

3 participants