-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Change siteId
to a String
type
#129
Labels
enhancement
New feature or request
good first issue
Good for newcomers
priority-low
Low priority issues or PR
Comments
we have tested it with our setup, can raise a PR for the same. |
TesteurManiak
added
enhancement
New feature or request
good first issue
Good for newcomers
priority-low
Low priority issues or PR
labels
Dec 27, 2023
Sure! I don't see any problem with changing |
TesteurManiak
changed the title
Support for joubertredrat/Matomo-ProtectTrackID
Feat: Change Dec 27, 2023
siteId
to a String
type
jainhitesh9998
added a commit
to jainhitesh9998/matomo-tracker
that referenced
this issue
Dec 28, 2023
Changed type of siteId to String
Merged
TesteurManiak
added a commit
that referenced
this issue
Dec 29, 2023
Just upgraded from 4.x to 5.0 and found this breaking change. This should be mentioned in the upgrade guide. |
@ken717w Documentation has been updated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
New feature or request
good first issue
Good for newcomers
priority-low
Low priority issues or PR
Describe the bug
A clear and concise description of what the bug is.
Configuring Matomo-ProtectTrackID enables us to use hash instead of int as part of site-id.
Changing the datatype of siteid from in to String has no affect on the functionality, but improves the compatibility with the ProtectTrackID library as the site id generated then are string.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):
Smartphone (please complete the following information):
Additional context
Add any other context about the problem here.
The text was updated successfully, but these errors were encountered: