Bugfix for extended DataProvider cloning #347
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…class adds new method clone() which subclasses must re-implement
|
Would be great if this could get merged - was just working on a PR to do the same thing before I came across this |
sbearben
reviewed
Jul 12, 2019
| @@ -24,6 +24,11 @@ export default class DataProvider { | |||
| this.getStableId = (index) => index.toString(); | |||
| } | |||
| } | |||
|
|
|||
| public clone(): DataProvider { | |||
There was a problem hiding this comment.
Would it make sense for this method to be protected?
|
@sbearben @DevopsElectricJukebox This fix is already in master. Instead of extending from |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(This PR replaces #346)
It is not possible to use
cloneWithRows(items)method on a class which extendsDataProvider, the method will create an instance of the base class and not the extended class. This has been remedied by providing a separateclone()method which the subclass can re-implement.clone()is then called incloneWithRows(items)instead ofnew DataProvider.