Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: explicit record class declarations #94

Merged
merged 10 commits into from
Feb 3, 2022
Merged

feat: explicit record class declarations #94

merged 10 commits into from
Feb 3, 2022

Conversation

Flash0ver
Copy link
Owner

closes #82
closes #90

@Flash0ver
docs(README): add link to NuGet Package Explorer
7df482c
@Flash0ver
build: move nullable suppression to root
085fa4a 
from Analyzers project
@Flash0ver
build!: update Roslyn from 3.8 to 4.0
d095ea2 
add support for Visual Studio 2022 to the VSIX

BREAKING CHANGE: drop support for .NET 5.0 SDK and Visual Studio 2019
@Flash0ver
fix(null-checks): report on static bool Equals(object) methods
405e80d
@Flash0ver
feat: add analyzer for reference records without class keyword
b6d2279 
Warning F02001
@Flash0ver
feat: add fixer for F02001
3d5927f 
add optional class keyword to records that are reference types
@Flash0ver
style: fix indentation after change to file-scoped namespaces
34417f4
@Flash0ver
refactor: update nullable annotations
bd3206c 
after updating to Roslyn 4.0.1
@Flash0ver
build: add missing example projects to filtered solution
2e4a291
@Flash0ver
docs: fix typo
207c1fd
@Flash0ver Flash0ver added this to the vNext milestone Jan 29, 2022
NKnusperer
NKnusperer approved these changes Feb 1, 2022
View reviewed changes
Copy link
Collaborator

@NKnusperer NKnusperer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

TimoHeiten
TimoHeiten approved these changes Feb 1, 2022
View reviewed changes
Copy link
Collaborator

@TimoHeiten TimoHeiten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tbh I cannot really say too much for the logic, as I do not understand all of it.

The code itself looks fine enough though. :)

@Flash0ver Flash0ver merged commit acf5fe7 into main Feb 3, 2022
@Flash0ver Flash0ver deleted the feat/explicit-record-class-declaration branch February 3, 2022 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TimoHeiten TimoHeiten TimoHeiten approved these changes

@NKnusperer NKnusperer NKnusperer approved these changes

@daaannniii daaannniii Awaiting requested review from daaannniii

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.9.0
Development

Successfully merging this pull request may close these issues.

Reference record types should be declared with the class keyword Update VSIX to support Visual Studio 2022
3 participants
@Flash0ver @NKnusperer @TimoHeiten