-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: rate limiting issue when downloading flank with no version supplied #2360
fix: rate limiting issue when downloading flank with no version supplied #2360
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
78563e1
to
5b4c0ca
Compare
@flank-it |
Integration tests failed ❌ |
@flank-it |
Integration tests succeed for all OSs ✅ |
Are you able to merge this now? Edit: apparently external contributors are not allowed to merge |
…n supplied (Flank#2360)" This reverts commit 9b7d6eb.
This seems to be breaking things with the following error
I can't seem to revert the changes but I'll open another PR to fix the issue. It will mean the previous issue (rate-limiting) still exists, but obviously that's better than breaking the whole action. |
Fixes #2344
Test Plan
Tests should work
Gradle command should work
Checklist