Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rate limiting issue when downloading flank with no version supplied #2360

Merged
merged 4 commits into from
Apr 28, 2023

Conversation

ryancfogarty
Copy link

Fixes #2344

Test Plan

How do we know the code works?

Tests should work
Gradle command should work

Checklist

  • Documented
  • Unit tested
  • Integration tests updated

@google-cla
Copy link

google-cla bot commented Apr 6, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@Fry-kun Fry-kun changed the title Fix rate limiting issue when downloading flank with no version supplied fix: rate limiting issue when downloading flank with no version supplied Apr 13, 2023
@ryancfogarty ryancfogarty force-pushed the fix-rate-limit-issue-on-download branch from 78563e1 to 5b4c0ca Compare April 26, 2023 13:17
@ryancfogarty
Copy link
Author

@flank-it

@github-actions
Copy link
Contributor

github-actions bot commented Apr 26, 2023

Integration tests failed ❌
Windows status failure - Build scan:
MacOS status failure - Build scan:
Linux status failure - Build scan:
Workflow run https://github.com/Flank/flank/actions/runs/4809184961

@Fry-kun
Copy link
Collaborator

Fry-kun commented Apr 27, 2023

@flank-it

@github-actions
Copy link
Contributor

github-actions bot commented Apr 27, 2023

Integration tests succeed for all OSs ✅
Windows Build scan:
MacOS Build scan:
Linux Build scan:
Workflow run https://github.com/Flank/flank/actions/runs/4824095760

@Fry-kun
Copy link
Collaborator

Fry-kun commented Apr 28, 2023

Are you able to merge this now?

Edit: apparently external contributors are not allowed to merge

@Fry-kun Fry-kun merged commit 9b7d6eb into Flank:master Apr 28, 2023
ryancfogarty pushed a commit to ryancfogarty/flank that referenced this pull request May 2, 2023
@ryancfogarty
Copy link
Author

ryancfogarty commented May 2, 2023

This seems to be breaking things with the following error

Error: Flank/flank/master/action.yml (Line: 33, Col: 12): Unrecognized named-value: 'secrets'. Located at position 1 within expression: secrets.GITHUB_TOKEN
Error: GitHub.DistributedTask.ObjectTemplating.TemplateValidationException: The template is not valid. Flank/flank/master/action.yml (Line: 33, Col: 12): Unrecognized named-value: 'secrets'. Located at position 1 within expression: secrets.GITHUB_TOKEN
   at GitHub.DistributedTask.ObjectTemplating.TemplateValidationErrors.Check()
   at GitHub.Runner.Worker.ActionManifestManager.ConvertRuns(IExecutionContext executionContext, TemplateContext templateContext, TemplateToken inputsToken, String fileRelativePath, MappingToken outputs)
   at GitHub.Runner.Worker.ActionManifestManager.Load(IExecutionContext executionContext, String manifestFile)
Error: Fail to load Flank/flank/master/action.yml

I can't seem to revert the changes but I'll open another PR to fix the issue. It will mean the previous issue (rate-limiting) still exists, but obviously that's better than breaking the whole action.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

flank makes unauthenticated requests to github API
2 participants