-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add Flank version info to requests #2073
Conversation
Timestamp: 2021-07-08 08:56:56 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah, this isn't the right approach.
application name should stay the same. otherwise google is unable to pull stats on the flank client.
version info should be sent using client info details (as mentioned on the ticket)
Thanks for the feedback, here is a current
I hope now everything is fine. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks good to me!
let's have one other member of the team approve as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
return self._messages.TestMatrix(
testSpecification=spec,
environmentMatrix=environment_matrix,
clientInfo=client_info,
resultStorage=results,
flakyTestAttempts=self._args.num_flaky_test_attempts or 0)
I looked at the code in gcloud and we're suppose to set clientInfo on the TestMatrix object, not via a testing request initializer.
Right, thanks! I changed my implementation to using client info on the TestMatrix. |
Fixes #1925
Test Plan
In user agent Flank, sends version and revision.
This change adds version and revision to user agent by
setApplicationName
method. Let me know if it's fine. We can also add a new headerclient_info
by usingsetTestingRequestInitializer
andsetToolResultsRequestInitializer
.