Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Send missing analytics data from Flank to Mixpanel #2042

Merged
merged 16 commits into from
Jun 24, 2021
Merged

feat: Send missing analytics data from Flank to Mixpanel #2042

merged 16 commits into from
Jun 24, 2021

Conversation

adamfilipow92
Copy link
Contributor

@adamfilipow92 adamfilipow92 commented Jun 21, 2021 •
edited
Loading

Fixes #2030

Test Plan

How do we know the code works?

Mixpanel contains the following events:

  • configuration
  • bundle id / package id
  • total cost
  • device type
  • flank version

Checklist

  • Documented

@github-actions github-actions bot added the P0 label Jun 21, 2021
Sloox
Sloox suggested changes Jun 22, 2021
View reviewed changes
Copy link
Contributor

@Sloox Sloox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some language changes :)

docs/flank_mixpanel_metrics.md Outdated Show resolved Hide resolved
docs/flank_mixpanel_metrics.md Outdated Show resolved Hide resolved
docs/flank_mixpanel_metrics.md Outdated Show resolved Hide resolved
docs/flank_mixpanel_metrics.md Outdated Show resolved Hide resolved
docs/flank_mixpanel_metrics.md Outdated Show resolved Hide resolved
docs/flank_mixpanel_metrics.md Outdated Show resolved Hide resolved
docs/flank_mixpanel_metrics.md Outdated Show resolved Hide resolved
docs/flank_mixpanel_metrics.md Outdated Show resolved Hide resolved
adamfilipow92 and others added 9 commits June 22, 2021 14:14
@github-actions
Copy link
Contributor

github-actions bot commented Jun 22, 2021 •
edited
Loading

Timestamp: 2021-06-24 12:32:11
Buildscan url for ubuntu-workflow run 967919266
https://gradle.com/s/2veehmvirrdx4

@adamfilipow92 adamfilipow92 marked this pull request as ready for review June 24, 2021 12:13
Sloox
Sloox approved these changes Jun 24, 2021
View reviewed changes
Copy link
Contributor

@Sloox Sloox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mergify mergify bot merged commit cabab70 into master Jun 24, 2021
@mergify mergify bot deleted the 2030-missing-usage-statistics branch June 24, 2021 12:44
@github-actions github-actions bot locked and limited conversation to collaborators Jun 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@piotradamczyk5 piotradamczyk5 piotradamczyk5 approved these changes

@Sloox Sloox Sloox approved these changes

Assignees

@pawelpasterz pawelpasterz

@adamfilipow92 adamfilipow92

Labels
P0 Tiger 🐯
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Send missing analytics data from Flank to Mixpanel
4 participants
@adamfilipow92 @Sloox @piotradamczyk5 @pawelpasterz