Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Dumpshards fix #1 #2010

Merged
merged 4 commits into from
Jun 8, 2021
Merged

fix: Dumpshards fix #1 #2010

merged 4 commits into from
Jun 8, 2021

Conversation

Sloox
Copy link
Contributor

@Sloox Sloox commented Jun 7, 2021 •
edited
Loading

After numerous local checks it works locally.
It still needs to be tested once its merged.

Test Plan

How do we know the code works?
We test.

Checklist

All testing was done locally.

  • Windows 👍
  • Linux: 👍
  • MacOS 👍

@Sloox Sloox added the Bug label Jun 7, 2021
@Sloox Sloox self-assigned this Jun 7, 2021
pawelpasterz
pawelpasterz reviewed Jun 7, 2021
View reviewed changes
Copy link
Contributor

@pawelpasterz pawelpasterz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No gaurentee for a fix here as xargs is causing issues and can only be tested once merged :(

Hm...I might be missing something but your changes are mainly in test_runner module so those should be 'testable'

Anyway, I think it would be worth to run IT

integration_tests/src/test/resources/cases/flank_android_single_legacy.yml
@@ -5,4 +5,5 @@ gcloud:
flank:
disable-sharding: true
output-report: json
disable-usage-statistics: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@github-actions
Copy link
Contributor

github-actions bot commented Jun 7, 2021 •
edited
Loading

Timestamp: 2021-06-08 08:29:22
Buildscan url for ubuntu-workflow run 917632346
https://gradle.com/s/5s2agdhhvbjbm

@Sloox
Copy link
Contributor Author

Sloox commented Jun 8, 2021

@pawelpasterz I have run it locally and they pass. Will attach some logs if i can shortly.

@Sloox Sloox enabled auto-merge (squash) June 8, 2021 08:57
@Sloox Sloox merged commit 6bf3b27 into master Jun 8, 2021
@Sloox Sloox deleted the 1785-dump-shards-fix branch June 8, 2021 12:27
@github-actions github-actions bot locked and limited conversation to collaborators Jun 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@piotradamczyk5 piotradamczyk5 piotradamczyk5 approved these changes

@pawelpasterz pawelpasterz pawelpasterz approved these changes

@adamfilipow92 adamfilipow92 Awaiting requested review from adamfilipow92

Assignees

@Sloox Sloox

Labels
Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Sloox @pawelpasterz @piotradamczyk5