Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Implement tool for parallel execution #2009

Merged
merged 29 commits into from
Jun 20, 2021
Merged

feat: Implement tool for parallel execution #2009

merged 29 commits into from
Jun 20, 2021

Conversation

jan-goral
Copy link
Contributor

@jan-goral jan-goral commented Jun 7, 2021 •
edited
Loading

Fixes #2001

Parallel execution algorithm

Example graph execution

example-graph

Algorithm

parallel-execution

Functions

parallel-execution

Types

parallel-execution

Different graph states

parallel-execution

Test Plan

How do we know the code works?

Unit tests are passing.

Checklist

  • Documented
  • Unit tested

@jan-goral jan-goral self-assigned this Jun 7, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Jun 9, 2021 •
edited
Loading

Timestamp: 2021-06-20 11:57:12
Buildscan url for ubuntu-workflow run 954363918
https://gradle.com/s/y34vt6jiqmcse

@jan-goral jan-goral force-pushed the 2001_Implement_tool_for_parallel_execution branch 3 times, most recently from 26e06a6 to bb5f43d Compare June 11, 2021 06:48
@jan-goral jan-goral marked this pull request as ready for review June 11, 2021 06:53
@mergify
Copy link

mergify bot commented Jun 11, 2021

Title does not follow the guidelines of Conventional Commits.
Please adjust title before merge and use one of following prefix:

  • build - Changes that affect the build system or external dependencies (dependencies update)
  • ci - Changes to our CI configuration files and scripts (basically directory .github/workflows)
  • docs - Documentation only changes
  • feat - A new feature
  • fix - A bug fix
  • chore - Changes which does not touch the code (ex. manual update of release notes). It will not generate release notes changes
  • refactor - A code change that contains refactor
  • style - Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • test - Adding missing tests or correcting existing tests and also changes for our test app
  • perf - A code change that improves performance (I do not think we will use it)

@jan-goral jan-goral changed the title 2001 implement tool for parallel execution feat: implement tool for parallel execution Jun 11, 2021
@bootstraponline bootstraponline force-pushed the 2001_Implement_tool_for_parallel_execution branch from 7741487 to 8572375 Compare June 11, 2021 11:18
@jan-goral jan-goral force-pushed the 2001_Implement_tool_for_parallel_execution branch from 914f620 to 5d56150 Compare June 13, 2021 15:52
@jan-goral jan-goral changed the title feat: implement tool for parallel execution feat: Implement tool for parallel execution Jun 14, 2021
@bootstraponline bootstraponline force-pushed the 2001_Implement_tool_for_parallel_execution branch from 9aebe9a to f3dbf00 Compare June 14, 2021 11:11
Sloox
Sloox reviewed Jun 14, 2021
View reviewed changes
Copy link
Contributor

@Sloox Sloox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Part one of simple review as its a large review to do.

tool/execution/parallel/README.md Outdated Show resolved Hide resolved
tool/execution/parallel/README.md Outdated Show resolved Hide resolved
tool/execution/parallel/README.md Outdated Show resolved Hide resolved
@bootstraponline bootstraponline force-pushed the 2001_Implement_tool_for_parallel_execution branch from 7b1a5d2 to 4562dcc Compare June 15, 2021 15:51
@Sloox Sloox self-requested a review June 16, 2021 14:55
@bootstraponline bootstraponline force-pushed the 2001_Implement_tool_for_parallel_execution branch 2 times, most recently from 2d23513 to b91ba0b Compare June 18, 2021 09:50
Sloox
Sloox approved these changes Jun 18, 2021
View reviewed changes
Copy link
Contributor

@Sloox Sloox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a very large PR. Phew 😟

jan-goral and others added 24 commits June 20, 2021 13:47
@jan-goral
Make context dsl protected
181841e 
Split & Update diagram
@jan-goral
Update
aa66515
@jan-goral
Update
fdfe182
@jan-goral
Update
bc0e85d
@jan-goral
Improve graph validation
90e95af
@jan-goral
Remove unneeded error type
71c4277
@jan-goral
Rollback gradle version
23d972f
@jan-goral
Format kotlin
c202cdf
@jan-goral
Remove wildcards
9fafbef
@jan-goral
Update doc
d7bf537
@jan-goral
Add example graph
6d50223
@jan-goral
Update README.md
37bdcf2
@jan-goral
Update README.md
2fbf097
@jan-goral
Update README.md
f6dfad9
@jan-goral
Update references
54e4159
@jan-goral
Update parallel-execution-api-structures.puml
169f98c
@jan-goral
Update parallel-execution-api-structures.puml
76e1225
@jan-goral
Fix flaky test
72245e8
@jan-goral
Update parallel-execution-api-functions.puml
2214312
@jan-goral
Small fix
5bd3d32
@jan-goral
Remove unneeded values from state when expected types are specified.
4926c25 
Optimize reduce graph algorithm.
Add benchmarks for core functions
Small fixes
@jan-goral
Update diagram
cbb0a0b
@jan-goral
Fix gradle version
1838aa7
@jan-goral @Sloox
Apply suggestions from code review
7a6bcda 
Co-authored-by: Michael Wright <[email protected]>
@jan-goral jan-goral force-pushed the 2001_Implement_tool_for_parallel_execution branch from b91ba0b to 7a6bcda Compare June 20, 2021 11:50
@mergify mergify bot merged commit 3b5535c into master Jun 20, 2021
@mergify mergify bot deleted the 2001_Implement_tool_for_parallel_execution branch June 20, 2021 12:03
@github-actions github-actions bot locked and limited conversation to collaborators Jun 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pawelpasterz pawelpasterz pawelpasterz approved these changes

@Sloox Sloox Sloox approved these changes

@adamfilipow92 adamfilipow92 Awaiting requested review from adamfilipow92

@zuziaka zuziaka Awaiting requested review from zuziaka

@piotradamczyk5 piotradamczyk5 Awaiting requested review from piotradamczyk5

Assignees

@jan-goral jan-goral

Labels
Corellium
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement tool for parallel execution
3 participants
@jan-goral @Sloox @pawelpasterz