Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Bash/Shell Environment #1770

Closed
Sloox opened this issue Apr 1, 2021 · 1 comment · Fixed by #2127
Closed

Refactor Bash/Shell Environment #1770

Sloox opened this issue Apr 1, 2021 · 1 comment · Fixed by #2127
Assignees

Comments

@Sloox
Copy link
Contributor

Sloox commented Apr 1, 2021

Author the user story for this feature

Due to the inclusion of Windows, Linux and MacOs and the possible iterations in the future (M1 mac for example) a proper shell/bash environment needs to be created and handled.

Describe the solution

Specifically it can be expanded as follows:

  1. Handle all the iterations of shell environments for each OS (Bash, BinBash, CMD, Powershell etc)
  2. A way to store and handle external commands to be run through the Shell above (NM, Swift demangle etc)
  3. Make sure its easy to extend when needed and compatible with the Os we have identified.
  4. Follow good principles as set out by the flank
@Sloox
Copy link
Contributor Author

Sloox commented Jun 28, 2021

There are issues that are occuring in our current implementation (As of 6/28/2021) see : #2048

@piotradamczyk5 piotradamczyk5 self-assigned this Jul 30, 2021
@mergify mergify bot closed this as completed in #2127 Aug 9, 2021
mergify bot pushed a commit that referenced this issue Aug 9, 2021
Fixes #1770

## Test Plan
> How do we know the code works?

Code is refactored according to #1770. All commands works as previously
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants