Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Set tag to get or create #4790

Merged
merged 2 commits into from
Nov 1, 2024
Merged

Conversation

zachaysan
Copy link
Contributor

Changes

Updated the FeatureExternalResource AFTER_SAVE hook to create a tag if it doesn't exist.

How did you test this code?

Copied an existing test but altered it so that no tags were present then verified that the tag was created.

@zachaysan zachaysan requested a review from a team as a code owner October 31, 2024 14:15
@zachaysan zachaysan requested review from khvn26 and removed request for a team October 31, 2024 14:15
Copy link

vercel bot commented Oct 31, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Oct 31, 2024 2:15pm
flagsmith-frontend-preview ⬜️ Ignored (Inspect) Oct 31, 2024 2:15pm
flagsmith-frontend-staging ⬜️ Ignored (Inspect) Oct 31, 2024 2:15pm

@github-actions github-actions bot added the api Issue related to the REST API label Oct 31, 2024
Copy link
Contributor

github-actions bot commented Oct 31, 2024

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-4790 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-4790 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-frontend:pr-4790 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-api:pr-4790 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-4790 Finished ✅ Results

@github-actions github-actions bot added the fix label Oct 31, 2024
Copy link
Contributor

github-actions bot commented Oct 31, 2024

Uffizzi Preview deployment-57817 was deleted.

Copy link

codecov bot commented Oct 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.33%. Comparing base (483cc87) to head (02f5a6d).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4790   +/-   ##
=======================================
  Coverage   97.32%   97.33%           
=======================================
  Files        1179     1179           
  Lines       41188    41201   +13     
=======================================
+ Hits        40088    40101   +13     
  Misses       1100     1100           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matthewelwell matthewelwell added this pull request to the merge queue Nov 1, 2024
Merged via the queue into main with commit fedd296 Nov 1, 2024
34 checks passed
@matthewelwell matthewelwell deleted the fix/set_tag_to_get_or_create branch November 1, 2024 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants