You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@kyle-ssggroup_admin has now been added to the user objects in the response to the GET /organisations/:id/groups/ endpoint. This has been deployed to staging so I think you can test this using the staging preview?
@kyle-ssg this is a great addition, and seems to work well. The only criticism I would have is that it's very hidden - to get there, you have to click on 'Edit Permissions' which seems a bit odd. I'm not sure what the solution is here to be honest, maybe we can simply just change it to 'Manage user' ?
Also, I'd argue that it's something that might be useful for admins now too - groups aren't only used for permissions - you can assign features and change requests to them, for example.
featureNew feature or requestfront-endIssue related to the React Front End Dashboard
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
pre-commit
to check lintingdocs/
if required so people know about the feature!Changes
Todo: the API needs to return group_admin in /organisations/:id/groups for this to function correctly
How did you test this code?
Viewed / adjusted user permissions