Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Manage user's groups #4312

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

feat: Manage user's groups #4312

wants to merge 6 commits into from

Conversation

kyle-ssg
Copy link
Member

@kyle-ssg kyle-ssg commented Jul 9, 2024

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Todo: the API needs to return group_admin in /organisations/:id/groups for this to function correctly

image

How did you test this code?

Viewed / adjusted user permissions

@kyle-ssg kyle-ssg requested a review from a team as a code owner July 9, 2024 09:25
@kyle-ssg kyle-ssg requested review from novakzaballa and removed request for a team July 9, 2024 09:25
Copy link

vercel bot commented Jul 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 9, 2024 1:37pm
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 9, 2024 1:37pm
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 9, 2024 1:37pm

Copy link
Contributor

github-actions bot commented Jul 9, 2024

flagsmith-private-cloud image build and security scan finished ✨

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-private-cloud:pr-4312 Finished ✅ Results

Copy link
Contributor

github-actions bot commented Jul 9, 2024

flagsmith image build and security scan finished ✨

Image Build Status Security report
ghcr.io/flagsmith/flagsmith:pr-4312 Finished ✅ Results

Copy link
Contributor

github-actions bot commented Jul 9, 2024

flagsmith-e2e image build finished ✨

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-e2e:pr-4312 Finished ✅ Skipped

Copy link
Contributor

github-actions bot commented Jul 9, 2024

flagsmith-frontend image build and security scan finished ✨

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-frontend:pr-4312 Finished ✅ Results

Copy link
Contributor

github-actions bot commented Jul 9, 2024

flagsmith-api image build and security scan finished ✨

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api:pr-4312 Finished ✅ Results

Copy link
Contributor

github-actions bot commented Jul 9, 2024

Uffizzi Ephemeral Environment deployment-57024

☁️ https://app.uffizzi.com/github.com/Flagsmith/flagsmith/pull/4312

📄 View Application Logs etc.

What is Uffizzi? Learn more!

# Conflicts:
#	frontend/web/components/pages/UsersAndPermissionsPage.tsx
# Conflicts:
#	frontend/web/components/pages/UsersAndPermissionsPage.tsx
@matthewelwell
Copy link
Contributor

@kyle-ssg group_admin has now been added to the user objects in the response to the GET /organisations/:id/groups/ endpoint. This has been deployed to staging so I think you can test this using the staging preview?

@matthewelwell
Copy link
Contributor

@kyle-ssg this is a great addition, and seems to work well. The only criticism I would have is that it's very hidden - to get there, you have to click on 'Edit Permissions' which seems a bit odd. I'm not sure what the solution is here to be honest, maybe we can simply just change it to 'Manage user' ?

@matthewelwell
Copy link
Contributor

Also, I'd argue that it's something that might be useful for admins now too - groups aren't only used for permissions - you can assign features and change requests to them, for example.

@matthewelwell
Copy link
Contributor

Screenshot 2024-10-30 at 13 45 54

@matthewelwell matthewelwell marked this pull request as ready for review October 30, 2024 13:48
@github-actions github-actions bot added feature New feature or request and removed feature New feature or request labels Oct 30, 2024
Copy link
Contributor

github-actions bot commented Oct 30, 2024

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-4312 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-4312 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-4312 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-4312 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-4312 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-frontend:pr-4312 Finished ✅ Results

@matthewelwell matthewelwell requested review from matthewelwell and removed request for khvn26 October 30, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request front-end Issue related to the React Front End Dashboard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a convenient permissions view for group/project/organisation admins
2 participants