Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(build): Avoid Docker Hub pull throttling by using public ECR registry #4292

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

khvn26
Copy link
Member

@khvn26 khvn26 commented Jul 8, 2024

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

This swaps out base images from Docker Hub to ones from Public ECR. This helps to avoid Docker Hub throttling on ARM64 runners (see actions/runner-images#1445 (comment)).

How did you test this code?

Pulled each of the new images and made sure they're identical to the ones from Docker Hub.

Copy link

vercel bot commented Jul 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Jul 8, 2024 1:29pm
flagsmith-frontend-preview ⬜️ Ignored (Inspect) Jul 8, 2024 1:29pm
flagsmith-frontend-staging ⬜️ Ignored (Inspect) Jul 8, 2024 1:29pm

@github-actions github-actions bot added the fix label Jul 8, 2024
Copy link
Contributor

github-actions bot commented Jul 8, 2024

flagsmith-frontend image build and security scan finished ✨

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-frontend:pr-4292 Finished ✅ Results

Copy link
Contributor

github-actions bot commented Jul 8, 2024

flagsmith image build and security scan finished ✨

Image Build Status Security report
ghcr.io/flagsmith/flagsmith:pr-4292 Finished ✅ Results

Copy link
Contributor

github-actions bot commented Jul 8, 2024

flagsmith-api image build and security scan finished ✨

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api:pr-4292 Finished ✅ Results

Copy link
Contributor

github-actions bot commented Jul 8, 2024

flagsmith-private-cloud image build and security scan finished ✨

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-private-cloud:pr-4292 Finished ✅ Results

Copy link
Contributor

github-actions bot commented Jul 8, 2024

flagsmith-e2e image build finished ✨

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-e2e:pr-4292 Finished ✅ Skipped

Copy link
Contributor

github-actions bot commented Jul 8, 2024

Uffizzi Preview deployment-53944 was deleted.

@khvn26 khvn26 added this pull request to the merge queue Jul 8, 2024
Merged via the queue into main with commit 30bed4e Jul 8, 2024
28 checks passed
@khvn26 khvn26 deleted the fix/avoid-docker-pull-throttling branch July 8, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants