Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix highlight encoding #2558

Merged
merged 1 commit into from
Aug 1, 2023
Merged

fix: Fix highlight encoding #2558

merged 1 commit into from
Aug 1, 2023

Conversation

kyle-ssg
Copy link
Member

@kyle-ssg kyle-ssg commented Aug 1, 2023

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

The highlight component was incorrectly directly setting HTML, possibly to attempt highlighting code as it's being adjusted. This caused a couple issues:

  • Content was modified to be unescaped HTML
  • Highlighting was breaking

How did you test this code?

Created a HTML remote config and switched languages whilst editing

@vercel
Copy link

vercel bot commented Aug 1, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Aug 1, 2023 11:03am
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview Aug 1, 2023 11:03am
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 1, 2023 11:03am

@github-actions
Copy link
Contributor

github-actions bot commented Aug 1, 2023

Uffizzi Preview deployment-32235 was deleted.

@kyle-ssg kyle-ssg merged commit 717f175 into main Aug 1, 2023
10 of 11 checks passed
@kyle-ssg kyle-ssg deleted the chore/fix_highlight_encoding branch August 1, 2023 11:42
This was referenced Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
front-end Issue related to the React Front End Dashboard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants