Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tests): test coverage #2482

Merged
merged 3 commits into from
Jul 20, 2023
Merged

feat(tests): test coverage #2482

merged 3 commits into from
Jul 20, 2023

Conversation

khvn26
Copy link
Member

@khvn26 khvn26 commented Jul 20, 2023

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

  • Remove xdist configuration from pyproject.toml for Pycharm test runner compatibility
  • Add xdist to make test environment
  • Add code coverage
  • Measure coverage in main
  • Add codecov upload

How did you test this code?

These changes are tested in CI.

@vercel
Copy link

vercel bot commented Jul 20, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 20, 2023 6:21pm
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 20, 2023 6:21pm
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 20, 2023 6:21pm

@github-actions
Copy link
Contributor

github-actions bot commented Jul 20, 2023

Uffizzi Preview deployment-31409 was deleted.

@codecov-commenter
Copy link

codecov-commenter commented Jul 20, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@a5d29ca). Click here to learn what that means.
Patch has no changes to coverable lines.

❗ Current head f204bdf differs from pull request most recent head e051bde. Consider uploading reports for the commit e051bde to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2482   +/-   ##
=======================================
  Coverage        ?   95.40%           
=======================================
  Files           ?      962           
  Lines           ?    26927           
  Branches        ?        0           
=======================================
  Hits            ?    25690           
  Misses          ?     1237           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@khvn26 khvn26 force-pushed the feat/test-coverage branch 2 times, most recently from 3c38751 to 304939a Compare July 20, 2023 17:44
- Remove xdist configuration from pyproject.toml for Pycharm test runner compatibility
- Add xdist to `make test` environment
- Add code coverage
- Measure coverage in main
- Add codecov upload
@dabeeeenster
Copy link
Contributor

Can we add a badge to the readme?

@khvn26
Copy link
Member Author

khvn26 commented Jul 20, 2023

Can we add a badge to the readme?

@dabeeeenster Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants