fix fetch from api after loading stale cache when skip api set #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blackjid
force-pushed
the
fix_load_stale_cache_skip_api
branch
from
ef9c2ad to
cba3282
Compare
kyle-ssg
approved these changes
Sep 18, 2024
kyle-ssg
reviewed
Sep 18, 2024
flagsmith-core.ts
Outdated
| const shouldFetchFlags = !preventFetch && ( | ||
| !this.cacheOptions.skipAPI || | ||
| !cachePopulated || | ||
| (cachePopulated && staleCachePopulated) |
There was a problem hiding this comment.
Hmm I think this can be tidied up, this is within an if(cachePopulated), so some of these are redundant ?
If I'm not mistaken should this be more like
// fetch the flags if the cache is stale, or if we're not skipping api on cache hits
const shouldFetchFlags = !preventFetch && (!this.cacheOptions.skipAPI || staleCachePopulated)
There was a problem hiding this comment.
I think you're right... :) much cleaner
blackjid
force-pushed
the
fix_load_stale_cache_skip_api
branch
from
c0ac849 to
ef4f22b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think I missed this in the #251 PR.
In this PR I added tests and code to maintain the behaviour of getting from the api when the cache expired and after loading the stale cache.
There is bad case where you might end up with a forever stale cache by using the
loadStale: true, when you expected that it always fetch when the cache has expired..cc: @kyle-ssg