-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Caching with multiple instance doesn't work #201
Comments
Thanks for this @ldemesla, we will look into it and get back to you as soon as possible. |
Thank you @ldemesla! we will soon start working on this issue, and keep you posted about the progress. |
@kyle-ssg @novakzaballa what's the status here? |
Hi @ldemesla, just to leave an update and let you know that we are considering if this use case would be solved by the implementation of contexts which is planned to be delivered by the second semester of this year. |
Hi @ldemesla we will start working on the contexts next week, could you please explain the use case for this request? so we can know this is a good candidate for solving this with the implementation of the contexts |
Also, we don't provide the function |
@novakzaballa I am interested in solving the problem, my use case is the use of cacheFlags in a microfrontend architecture where each project can have its own instance of flagsmith but they all share the same localStorage |
Hi @oluizcarvalho, that makes total sense to me. If you'd like to submit a PR for this, then we'd love to receive it! |
…ty to cacheOptions to customize the key
@matthewelwell PR open! 🚀 #246 |
#201 (feat): added envId to the storage key and added property to cacheOptions to customize the key
This has been resolved in version 6.0.0, thanks so much @oluizcarvalho |
Hey,
I'm using Flagsmith with two instances, created using the
createFlagsmithContext
. I have noticed that caching is not working properly when you are running two instances. Indeed, if you look at the local storage you will see that the values from both instance are cached against the same key and are overriding each other.Reproduction case:
Check in the local storage of your browser and you will see that only one of the identity has been cached
The text was updated successfully, but these errors were encountered: