Skip to content

Commit

Permalink
fs: fix .write() not coercing non-string values
Browse files Browse the repository at this point in the history
  • Loading branch information
Fishrock123 committed Mar 8, 2015
1 parent fe36076 commit 6d2a421
Show file tree
Hide file tree
Showing 2 changed files with 30 additions and 1 deletion.
2 changes: 1 addition & 1 deletion lib/fs.js
Original file line number Diff line number Diff line change
Expand Up @@ -629,7 +629,7 @@ fs.write = function(fd, buffer, offset, length, position, callback) {
return binding.writeBuffer(fd, buffer, offset, length, position, req);
}

if (typeof buffer === 'string')
if (typeof buffer !== 'string')
buffer += '';
if (typeof position !== 'function') {
if (typeof offset === 'function') {
Expand Down
29 changes: 29 additions & 0 deletions test/parallel/test-fs-write-string-coerce.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
var common = require('../common');
var assert = require('assert');
var path = require('path');
var Buffer = require('buffer').Buffer;
var fs = require('fs');
var fn = path.join(common.tmpDir, 'write-string-coerce.txt');
var data = true;
var expected = data + '';
var found;

fs.open(fn, 'w', 0644, function(err, fd) {
if (err) throw err;
console.log('open done');
fs.write(fd, data, 0, 'utf8', function(err, written) {
console.log('write done');
if (err) throw err;
assert.equal(Buffer.byteLength(expected), written);
fs.closeSync(fd);
found = fs.readFileSync(fn, 'utf8');
console.log('expected: "%s"', expected);
console.log('found: "%s"', found);
fs.unlinkSync(fn);
});
});


process.on('exit', function() {
assert.equal(expected, found);
});

0 comments on commit 6d2a421

Please sign in to comment.