Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecations for Ember/Ember-Data 2.12 #492

Merged

Conversation

m-basov
Copy link
Contributor

@m-basov m-basov commented Mar 23, 2017

Description

Since ember and ember-data 2.12 become stable there are deprecations needed to be fixed.

  1. _lookupFactoryForlink. I have added polyfill as suggested at Ember blog. Replaced with #resolveRegistration() method.
  2. _shouldSerializeHasManylink. It is now public API, but I kept both. Please let me know if you have any notices.

Some other changes:

  1. I have copied ember-try scenarios from this PR to test against new ember versions so original PR may be obsolete.
  2. ember-try scenarios contained wrong dependencies for ember-canary and ember-beta. I fixed them to use npm instead of bower.
  3. Tests have helper to get user by username or create new. It used removed method typeMapFor, now it uses _internalModelsFor.
  4. Coverage config had problems with linting because of env, I fixed it with jshint comment.

Local tests passed all scenarios and linting. Let see if it will works the same on Travis :)

EDIT.

There was problem with testem/firefox and I locked Firefox to 51 until fix.

Copy link
Contributor

@jamesdaniels jamesdaniels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the fixes and looking into the Firefox matter.

@jamesdaniels jamesdaniels merged commit d8021b8 into FirebaseExtended:master Mar 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants