Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Level up rewrite #539

Merged
merged 9 commits into from
Oct 5, 2023
Merged

Level up rewrite #539

merged 9 commits into from
Oct 5, 2023

Conversation

Vesly01
Copy link
Contributor

@Vesly01 Vesly01 commented Oct 4, 2023

  • Save level that you promote at in BWL->squares moved
  • Do not save squares moved (I don't think this is used anywhere)
  • Improve accuracy of fixed growths by accounting for the level you promote at
  • Rewrite Necessary/GrowthGetters/asm/Write_Growths_To_Battle_Struct.s using the C decomp function as a base
  • Add bracketed stats that stay within X points of the average, preventing becoming stat screwed and/or stat blessed, depending on your config.
  • This does not account for stat boosters (and fixed growths never has), as it would use up extra ram. If this is a problem to you, then set PREVENT_WHEN_ABOVE_AVERAGE_BY_AMOUNT to a high number.

@masterofcontroversy
Copy link
Contributor

What clib is this supposed to be using? Mokha's decomp compatible version and Stan's version are both implied to be used.

If Mokha's version is used, I think it'd be better to edit the makefile and definitions file to use the local installation of Mokha's clib to make compiling the code more straightforward in the future.

If Stan's version is used, why has Mokha's clib been locally added?

@Veslyquix
Copy link
Contributor

I just copied the header files from a folder of mine in pokemblem where I'd set things up earlier this year from the decomp. It should be similar to Mokha's setup I guess.

Definitions file shouldn't need the 2019 file and the makefile just references devkitpro for lyn.exe - the include is just if you type #include "gbafe.h" at the start, I believe. So the 2019 stuff isn't used at all afaik.

Copy link
Collaborator

@sme23 sme23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small config things

EngineHacks/Config.event Outdated Show resolved Hide resolved
EngineHacks/Config.event Outdated Show resolved Hide resolved
@Vesly01
Copy link
Contributor Author

Vesly01 commented Oct 5, 2023

If Mokha's version is used, I think it'd be better to edit the makefile and definitions file to use the local installation of Mokha's clib to make compiling the code more straightforward in the future.

I fixed the definitions.s file to not reference the 2019 version, but I'm not sure about how to edit the makefile to not have the $(CC) $(CFLAGS) -S $< -I C:/devkitPro/FE-CLib/include -o $@ -fverbose-asm -mlong-calls stuff

small config things

Fixed this stuff

@sme23 sme23 merged commit 3396182 into FireEmblemUniverse:master Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants