-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Level up rewrite #539
Level up rewrite #539
Conversation
Vesly01
commented
Oct 4, 2023
- Save level that you promote at in BWL->squares moved
- Do not save squares moved (I don't think this is used anywhere)
- Improve accuracy of fixed growths by accounting for the level you promote at
- Rewrite Necessary/GrowthGetters/asm/Write_Growths_To_Battle_Struct.s using the C decomp function as a base
- Add bracketed stats that stay within X points of the average, preventing becoming stat screwed and/or stat blessed, depending on your config.
- This does not account for stat boosters (and fixed growths never has), as it would use up extra ram. If this is a problem to you, then set PREVENT_WHEN_ABOVE_AVERAGE_BY_AMOUNT to a high number.
What clib is this supposed to be using? Mokha's decomp compatible version and Stan's version are both implied to be used. If Mokha's version is used, I think it'd be better to edit the makefile and definitions file to use the local installation of Mokha's clib to make compiling the code more straightforward in the future. If Stan's version is used, why has Mokha's clib been locally added? |
I just copied the header files from a folder of mine in pokemblem where I'd set things up earlier this year from the decomp. It should be similar to Mokha's setup I guess. Definitions file shouldn't need the 2019 file and the makefile just references devkitpro for lyn.exe - the include is just if you type |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small config things
I fixed the definitions.s file to not reference the 2019 version, but I'm not sure about how to edit the makefile to not have the
Fixed this stuff |