Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add an integration test for TestExecuteContract #87

Merged
merged 7 commits into from
Aug 23, 2023

Conversation

da1suk8
Copy link
Member

@da1suk8 da1suk8 commented Aug 18, 2023

Description

TestExecuteContract

This PR adds an integration test for ExecuteContract.

This test is written for a test that depends on the hackatom contract.
The events added by hackatom contract are as follows.

https://github.com/Finschia/cosmwasm/blob/d86b54571ef7861964548241da6d8cbf6f77090f/contracts/hackatom/src/contract.rs#L94-L97

The destination address was not available on the msg_server, so I did not compare events[2].Attributes[2].Value

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

@da1suk8 da1suk8 self-assigned this Aug 18, 2023
@codecov
Copy link

codecov bot commented Aug 18, 2023

Codecov Report

Merging #87 (e7682bb) into main (f36b389) will increase coverage by 0.06%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #87      +/-   ##
==========================================
+ Coverage   62.89%   62.95%   +0.06%     
==========================================
  Files          80       80              
  Lines        9965     9965              
==========================================
+ Hits         6267     6273       +6     
+ Misses       3373     3369       -4     
+ Partials      325      323       -2     

see 2 files with indirect coverage changes

@da1suk8 da1suk8 marked this pull request as ready for review August 20, 2023 22:47
Kynea0b
Kynea0b previously approved these changes Aug 21, 2023
x/wasm/keeper/msg_server_integration_test.go Outdated Show resolved Hide resolved
x/wasm/keeper/msg_server_integration_test.go Outdated Show resolved Hide resolved
x/wasm/keeper/msg_server_integration_test.go Outdated Show resolved Hide resolved
- change sender address
- move non-execute parts outside the loop
- change to use MsgExecuteContractFixture
170210
170210 previously approved these changes Aug 22, 2023
Copy link

@170210 170210 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@da1suk8 da1suk8 merged commit f1e3820 into Finschia:main Aug 23, 2023
@da1suk8 da1suk8 deleted the test/TestExecuteContract branch August 23, 2023 02:25
@zemyblue zemyblue mentioned this pull request Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants