forked from CosmWasm/wasmd
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add an integration test for TestExecuteContract #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #87 +/- ##
==========================================
+ Coverage 62.89% 62.95% +0.06%
==========================================
Files 80 80
Lines 9965 9965
==========================================
+ Hits 6267 6273 +6
+ Misses 3373 3369 -4
+ Partials 325 323 -2 |
da1suk8
requested review from
dudong2,
loloicci,
Kynea0b and
170210
as code owners
August 20, 2023 22:47
Kynea0b
previously approved these changes
Aug 21, 2023
170210
reviewed
Aug 21, 2023
- change sender address - move non-execute parts outside the loop - change to use MsgExecuteContractFixture
170210
previously approved these changes
Aug 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
170210
approved these changes
Aug 23, 2023
Kynea0b
approved these changes
Aug 23, 2023
4 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
TestExecuteContract
This PR adds an integration test for ExecuteContract.
This test is written for a test that depends on the hackatom contract.
The events added by hackatom contract are as follows.
https://github.com/Finschia/cosmwasm/blob/d86b54571ef7861964548241da6d8cbf6f77090f/contracts/hackatom/src/contract.rs#L94-L97
The destination address was not available on the msg_server, so I did not compare
events[2].Attributes[2].Value
Checklist:
CHANGELOG.md
client/docs/swagger-ui/swagger.yaml