forked from CosmWasm/wasmd
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add event checking to TestMigrateContract #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
da1suk8
changed the title
Test/test migrate contract
test: add event checking to TestMigrateContract
Aug 16, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #78 +/- ##
==========================================
+ Coverage 62.54% 62.71% +0.17%
==========================================
Files 80 80
Lines 9966 9966
==========================================
+ Hits 6233 6250 +17
+ Misses 3405 3385 -20
- Partials 328 331 +3 |
170210
reviewed
Aug 17, 2023
Co-authored-by: 170210 <[email protected]>
170210
previously approved these changes
Aug 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
170210
reviewed
Aug 18, 2023
I deleted |
170210
previously approved these changes
Aug 18, 2023
170210
approved these changes
Aug 18, 2023
Kynea0b
approved these changes
Aug 18, 2023
4 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
TestInstantiateContract
https://github.com/Finschia/wasmd/blob/main/docs/proto/proto-docs.md#msgmigratecontract
This PR adds an integration test for TestMigrateContract.
This test is based on https://github.com/CosmWasm/wasmd/blob/33df4aeaaa419f6aad07b94d64c0423bee0a2d21/x/wasm/keeper/msg_server_integration_test.go#L740-L825
Checklist:
CHANGELOG.md
client/docs/swagger-ui/swagger.yaml