Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add the test case for InactiveContract #75

Merged
merged 4 commits into from
Aug 17, 2023

Conversation

Kynea0b
Copy link

@Kynea0b Kynea0b commented Aug 16, 2023

Description

Add test case for InactiveContract
https://github.com/Finschia/wasmd/blob/main/docs/proto/proto-docs.md#lbm.wasm.v1.QueryInactiveContractRequest
https://github.com/Finschia/wasmd/blob/main/docs/proto/proto-docs.md#queryinactivecontractresponse

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly. (not needed)
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml (not needed)

@Kynea0b Kynea0b self-assigned this Aug 16, 2023
@Kynea0b Kynea0b force-pushed the test-add-to-InactiveContract branch from 74566ac to a9de5ab Compare August 16, 2023 15:35
@Kynea0b Kynea0b changed the title test: add the test case for InactiveContract test: add the test case for InactiveContract Aug 16, 2023
@codecov
Copy link

codecov bot commented Aug 16, 2023

Codecov Report

Merging #75 (0c1c75a) into main (07aec27) will increase coverage by 0.03%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #75      +/-   ##
==========================================
+ Coverage   62.32%   62.35%   +0.03%     
==========================================
  Files          80       80              
  Lines        9966     9966              
==========================================
+ Hits         6211     6214       +3     
+ Misses       3429     3427       -2     
+ Partials      326      325       -1     

see 2 files with indirect coverage changes

@Kynea0b Kynea0b marked this pull request as ready for review August 16, 2023 16:23
@Kynea0b Kynea0b requested a review from 170210 August 16, 2023 16:43
@170210 170210 self-requested a review August 17, 2023 05:56
Copy link

@170210 170210 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Kynea0b Kynea0b merged commit 87f69d6 into Finschia:main Aug 17, 2023
@zemyblue zemyblue mentioned this pull request Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants