Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add test cases to confirm output for PinnedCodes #64

Merged
merged 10 commits into from
Aug 14, 2023

Conversation

Kynea0b
Copy link

@Kynea0b Kynea0b commented Aug 9, 2023

Description

PinnedCodes: TestQueryPinnedCodes

Add a test case because we have not tested for pagination.

message QueryPinnedCodesResponse {
  repeated uint64 code_ids = 1 [ (gogoproto.customname) = "CodeIDs" ];
  // pagination defines the pagination in the response.
  cosmos.base.query.v1beta1.PageResponse pagination = 2;
}

spec:
https://github.com/CosmWasm/wasmd/blob/main/proto/cosmwasm/wasm/v1/query.proto#L236

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly. (not needed)
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml (not needed)

@Kynea0b Kynea0b marked this pull request as ready for review August 10, 2023 02:11
Copy link

@170210 170210 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add changelog in CHANGELOGS.md

x/wasm/keeper/querier_test.go Outdated Show resolved Hide resolved
@Kynea0b Kynea0b self-assigned this Aug 10, 2023
CHANGELOG.md Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
x/wasm/keeper/querier_test.go Outdated Show resolved Hide resolved
170210
170210 previously approved these changes Aug 14, 2023
Copy link

@170210 170210 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Kynea0b Kynea0b merged commit f0d52fc into Finschia:main Aug 14, 2023
@zemyblue zemyblue mentioned this pull request Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants