Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: run validateBasic for vote before AddVote #770

Merged
merged 2 commits into from
Mar 26, 2024

Conversation

jaeseung-bae
Copy link
Contributor

@jaeseung-bae jaeseung-bae commented Mar 26, 2024

Description

@jaeseung-bae jaeseung-bae changed the title fix: run validateBasic before adding vote fix: run validateBasic before AddVote Mar 26, 2024
@jaeseung-bae jaeseung-bae changed the title fix: run validateBasic before AddVote fix: run validateBasic for vote before AddVote Mar 26, 2024
@jaeseung-bae jaeseung-bae self-assigned this Mar 26, 2024
Copy link

codecov bot commented Mar 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.59%. Comparing base (e1be3c4) to head (6b462da).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #770      +/-   ##
==========================================
+ Coverage   66.52%   66.59%   +0.07%     
==========================================
  Files         285      285              
  Lines       37917    37920       +3     
==========================================
+ Hits        25225    25254      +29     
+ Misses      10885    10862      -23     
+ Partials     1807     1804       -3     
Files Coverage Δ
types/block.go 79.65% <100.00%> (+0.07%) ⬆️

... and 13 files with indirect coverage changes

@jaeseung-bae jaeseung-bae marked this pull request as ready for review March 26, 2024 03:05
@jaeseung-bae jaeseung-bae merged commit b954189 into Finschia:main Mar 26, 2024
23 checks passed
@jaeseung-bae jaeseung-bae deleted the fix/validate-vote branch March 26, 2024 04:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants