Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the check if binary is for amd64 #426

Merged
merged 1 commit into from
Jun 8, 2022
Merged

Remove the check if binary is for amd64 #426

merged 1 commit into from
Jun 8, 2022

Conversation

ulbqb
Copy link
Member

@ulbqb ulbqb commented Jun 6, 2022 •
edited
Loading

Description

This PR enables to run Localnet(4 nodes) with Docker on apple M1 chip.

This PR contains the following changes:

  • Remove the check if binary is for amd64

Closes: #424

@ulbqb ulbqb requested review from Kynea0b, torao and tnasu as code owners June 6, 2022 05:14
@CLAassistant
Copy link

CLAassistant commented Jun 6, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@ulbqb ulbqb changed the title Remove the amd64 binary check for localnode Remove the binary check for amd64 Jun 6, 2022
@ulbqb ulbqb changed the title Remove the binary check for amd64 Remove the check if binary is for amd64 Jun 6, 2022
@Kynea0b Kynea0b added the C: enhancement Classification: New feature or its request, or improvement in maintainability of code label Jun 6, 2022
@ulbqb ulbqb merged commit c7dd3dc into Finschia:main Jun 8, 2022
@ulbqb ulbqb deleted the fix/localnode_binary_check branch June 8, 2022 02:16
@tnasu tnasu mentioned this pull request Jun 20, 2022
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kynea0b Kynea0b Kynea0b approved these changes

@tnasu tnasu tnasu approved these changes

@torao torao torao approved these changes

Assignees

@ulbqb ulbqb

Labels
C: enhancement Classification: New feature or its request, or improvement in maintainability of code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Binary needs to be OS linux, ARCH amd64
5 participants
@ulbqb @CLAassistant @torao @tnasu @Kynea0b