This repository has been archived by the owner on Apr 20, 2023. It is now read-only.
feat: apply wasm opts #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think this PR is a part of this issue and does not directly close the issue. Is it right? |
I think This PR resolve the entire issue. Are there any more metrics that need to be added? |
|
Ah, Sorry. I missed our version of wasm has the metric feature. Thanks. |
loloicci
approved these changes
Aug 24, 2021
|
Me too, I didn't even know it was added. thanks for the review! |
shiki-tak
approved these changes
Aug 24, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: Finschia/finschia-sdk#308
Add wasm opts to enable telemetry.
Motivation and context
https://github.com/CosmWasm/wasmd/blob/93e2e669402dd96b99f223bc6176abef6e794455/cmd/wasmd/root.go#L204
The telemetry metrics is included :1317(API Server metrics).
e.g) recorded instantiate
{"Name":"wasm.contract.instantiate","Count":1,"Rate":2.222800064086914,"Sum":22.22800064086914,"Min":22.22800064086914,"Max":22.22800064086914,"Mean":22.22800064086914,"Stddev":0,"Labels":{}}]}How has this been tested?
Screenshots (if appropriate):
Checklist: