Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: apply detached x/wasmd #129

Merged
merged 2 commits into from
Jan 20, 2023
Merged

chore: apply detached x/wasmd #129

merged 2 commits into from
Jan 20, 2023

Conversation

zemyblue
Copy link
Member

@zemyblue zemyblue commented Jan 13, 2023

Signed-off-by: zemyblue [email protected]

Description

Apply detached x/wasmd cae21ecd251cea44f56209e0a4586ca2979c6c87

This x/wasmd is same with x/wasm module of lbm-sdk v0.46.0.
It is based on line/cosmwasm v1.0.0-0.6.0 and line/wasmvm v1.0.0-0.10.0.

And in this PR the deleted gov mint of x/foundation(Finschia/finschia-sdk#848) is applied, because it is already applied in the latest version to reference in line/wasmd

closed: #128

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Checklist:

  • I followed the contributing guidelines.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

@zemyblue zemyblue self-assigned this Jan 13, 2023
@zemyblue zemyblue marked this pull request as draft January 13, 2023 00:30
Signed-off-by: zemyblue <[email protected]>
@zemyblue zemyblue marked this pull request as ready for review January 14, 2023 06:44
Copy link
Contributor

@dudong2 dudong2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ulbqb ulbqb self-requested a review January 19, 2023 03:48
@zemyblue zemyblue merged commit cac3677 into main Jan 20, 2023
@zemyblue zemyblue deleted the apply_detached_wasmd branch January 20, 2023 06:02
torao added a commit that referenced this pull request Feb 1, 2023
…64 platform (#130)

* add build target linux/amd64

* add release builds for darwin/amd64 and darwin/arm64

The approach of cross-compiling for each platform on Linux was difficult for cases like LBM that required native compilation of C/C++. For this reason, I use compilers suitable for each OS to perform release builds. Along with this, the docker image for cross-compiling run from `make reproducible` and the shell script used for it are no longer required.

* add a dependent library to the artifact instead of a single binary

* change to run on self-hosted runner

* add changelog

* revert RELEASE_CHANGELOG.md and add it to CHANGELOG.md

This reverts commit 9c5929d.

* update changelog

* typo

Co-authored-by: Sujong Lee <[email protected]>

* chore: apply detached x/wasmd (#129)

* chore: apply detached x/wasmd

Signed-off-by: zemyblue <[email protected]>

* chore: add changelog

Signed-off-by: zemyblue <[email protected]>

Signed-off-by: zemyblue <[email protected]>

---------

Signed-off-by: zemyblue <[email protected]>
Co-authored-by: Sujong Lee <[email protected]>
Co-authored-by: zemyblue <[email protected]>
@zemyblue zemyblue mentioned this pull request Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Apply detached line/wasmd
3 participants