-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Map Ostracon:ErrTxInMap to lbm-sdk:ErrTxInMempoolCache #890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #890 +/- ##
=======================================
Coverage 62.31% 62.31%
=======================================
Files 652 652
Lines 79493 79493
=======================================
+ Hits 49534 49535 +1
+ Misses 27279 27278 -1
Partials 2680 2680
|
tkxkd0159
reviewed
Feb 9, 2023
dudong2
approved these changes
Feb 10, 2023
tkxkd0159
approved these changes
Feb 10, 2023
zemyblue
approved these changes
Feb 10, 2023
zemyblue
approved these changes
Feb 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
lbm-sdk needs to be mapped for new errors in ostracon(ErrTxInMap).
For this error, lbm-sdk maps errors in types/errors/errors.go to make it easier for users to handle.
An implementation concern is whether ErrInTxMempoolCache fully explains this error.
For this reason, I mapped it to ErrTxInMempoolCache, but I think renaming this error to ErrTxInMempool is also a way.
closes: #810
Motivation and context
How has this been tested?
Screenshots (if appropriate):
Checklist:
CHANGELOG.md
client/docs/swagger-ui/swagger.yaml