-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: TODO: use base64.URLEncoding to modify TestQueryBlockByHash #711
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #711 +/- ##
==========================================
+ Coverage 61.84% 61.88% +0.04%
==========================================
Files 874 874
Lines 98557 98590 +33
==========================================
+ Hits 60950 61011 +61
+ Misses 33973 33948 -25
+ Partials 3634 3631 -3
|
Ask questions to fully understand the context of the PR. Is it about preventing errors by making handlers instead of using gateway proxies? |
@tkxkd0159 I've fixed this: https://github.com/line/lbm-sdk/blob/289ca6b2d11f988d6d45e28edf691511d2764209/client/grpc/tmservice/service_test.go I haven't fixed this: #703 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
relates: #699
Motivation and context
I found out how to fix TODO
How has this been tested?
By unit test code
Screenshots (if appropriate):
Checklist:
CHANGELOG.md
client/docs/swagger-ui/swagger.yaml