-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: change AccAddressFromBech32 to MustAccAddressFromBech32 #691
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #691 +/- ##
==========================================
+ Coverage 61.18% 61.20% +0.01%
==========================================
Files 873 873
Lines 98501 98474 -27
==========================================
+ Hits 60265 60268 +3
+ Misses 34667 34615 -52
- Partials 3569 3591 +22
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update the change log. It would be nice to provide more detailed title and log.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please write the proper code link include commit hash when you write this github description or comment. Because if you use main or branch name, it can be changed through any update.
Understood I have updated. |
Description
Fixed from
AccAddressFromBech32
toMustAccAddressFromBech32
.MustAccAddressFromBech32
has error handling.https://github.com/line/lbm-sdk/blob/4250dfb146e92af16698d1359be413fa5b5158ff/types/address.go#L158-L165
The test was modified in reference to below.
https://github.com/CosmWasm/wasmd/blob/ccb2fdd0b6ed849eb94d58e0174f4fc34bce336c/x/wasm/keeper/keeper_test.go#L520-L524
(Here, the appropriate comparison was not made.)
Motivation and context
Since
AccAddressFromBech32
does not have error handling,MustAccAddressFromBech32
, which has error handling, was used.How has this been tested?
Checklist:
CHANGELOG.md
client/docs/swagger-ui/swagger.yaml