Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Change wasm proto path to original cosmwasm path #617

Merged
merged 3 commits into from
Aug 2, 2022

Conversation

zemyblue
Copy link
Member

@zemyblue zemyblue commented Aug 1, 2022

Description

Rollback the gRPC path of origin cosmwasm

  • proto/lbm/wasm/v1 -> proto/cosmwasm/v1

Replace the gRPC index of extension and status in ContractInfo

Fo compatibility for cosmwasm gRPC.

// ContractInfo stores a WASM contract instance
message ContractInfo {
  (skip)
  // Extension is an extension point to store custom metadata within the
  // persistence model.
  google.protobuf.Any extension = 7 [(cosmos_proto.accepts_interface) = "ContractInfoExtension"];
  // Status is a status of a contract
  ContractStatus status = 8;
}

The old lbm-sdk's extension index is 8 and status index is 7.

Motivation and context

Changes are required for compatibility with cosmwasm.

How has this been tested?

Screenshots (if appropriate):

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

@zemyblue zemyblue marked this pull request as draft August 1, 2022 11:30
@codecov
Copy link

codecov bot commented Aug 1, 2022

Codecov Report

Merging #617 (5e48717) into main (4995218) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #617      +/-   ##
==========================================
- Coverage   59.76%   59.74%   -0.02%     
==========================================
  Files         811      811              
  Lines       94491    94491              
==========================================
- Hits        56468    56456      -12     
- Misses      34560    34574      +14     
+ Partials     3463     3461       -2     
Impacted Files Coverage Δ
x/token/validation.go 70.90% <0.00%> (-21.82%) ⬇️
x/token/msgs.go 30.45% <0.00%> (-8.13%) ⬇️
x/foundation/foundation.go 74.72% <0.00%> (-0.37%) ⬇️
x/foundation/msgs.go 39.90% <0.00%> (ø)
x/collection/msgs.go 41.48% <0.00%> (+3.14%) ⬆️

Signed-off-by: zemyblue <[email protected]>
@zemyblue zemyblue marked this pull request as ready for review August 1, 2022 12:17
@zemyblue zemyblue self-assigned this Aug 1, 2022
@zemyblue zemyblue requested a review from tnasu August 1, 2022 12:22
@zemyblue zemyblue merged commit 7b64b7a into Finschia:main Aug 2, 2022
@zemyblue zemyblue deleted the change_wasm_proto_path branch August 2, 2022 12:03
@zemyblue zemyblue mentioned this pull request Oct 27, 2022
5 tasks
@zemyblue zemyblue mentioned this pull request Nov 28, 2022
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants