Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: apply Ostracon's changes that replace StakingPower with VotingPower and VotingPower with VotingWeight. #614

Merged
merged 6 commits into from
Jul 29, 2022
Merged

feat: apply Ostracon's changes that replace StakingPower with VotingPower and VotingPower with VotingWeight. #614

merged 6 commits into from
Jul 29, 2022

Conversation

zemyblue
Copy link
Member

@zemyblue zemyblue commented Jul 28, 2022 •
edited
Loading

Description

Apply Ostracon's change that replace StakingPower with VotingPower and VotingPower with VotingWeight.
Finschia/ostracon#449

Here is a list of changes.

  • StakingPower -> VotingPower
  • VotingPower -> VotingWeight

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

@zemyblue
feat: apply the ostracon's change that replace StakingPower with `V…
9b22188 
…otingPower` and `StakingPower` with `VotingWeight`.

Finschia/ostracon#449

Signed-off-by: zemyblue <[email protected]>
@zemyblue zemyblue marked this pull request as draft July 28, 2022 13:36
@zemyblue zemyblue changed the title feat: apply Ostracon's change that replace StakingPower with VotingPower and StaingPower with VotingPower. feat: apply Ostracon's changes that replace StakingPower with VotingPower and StakingPower with VotingPower. Jul 28, 2022
@codecov
Copy link

codecov bot commented Jul 28, 2022 •
edited
Loading

Codecov Report

Merging #614 (a2a2d76) into main (869c7e7) will increase coverage by 0.06%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #614      +/-   ##
==========================================
+ Coverage   59.70%   59.76%   +0.06%     
==========================================
  Files         811      811              
  Lines       94491    94491              
==========================================
+ Hits        56419    56476      +57     
+ Misses      34623    34545      -78     
- Partials     3449     3470      +21
Impacted Files Coverage Δ
crypto/keys/ed25519/ed25519.go 76.13% <ø> (ø)
crypto/keys/multisig/codec.go 100.00% <ø> (ø)
crypto/keys/secp256k1/secp256k1.go 88.63% <ø> (ø)
x/distribution/abci.go 0.00% <0.00%> (ø)
x/simulation/mock_ostracon.go 0.00% <0.00%> (ø)
x/ibc/testing/chain.go 2.72% <75.00%> (ø)
client/rpc/status.go 47.54% <100.00%> (ø)
crypto/ledger/amino.go 100.00% <100.00%> (ø)
x/distribution/keeper/allocation.go 82.07% <100.00%> (ø)
x/foundation/foundation.go 72.92% <0.00%> (-0.37%) ⬇️
... and 6 more

@zemyblue zemyblue self-assigned this Jul 29, 2022
@zemyblue zemyblue requested review from dudong2, 0Tech, tnasu and torao July 29, 2022 05:32
@zemyblue zemyblue marked this pull request as ready for review July 29, 2022 05:32
dudong2
dudong2 approved these changes Jul 29, 2022
View reviewed changes
third_party/proto/ostracon/types/evidence.proto Outdated Show resolved Hide resolved
@dudong2
Copy link
Contributor

dudong2 commented Jul 29, 2022

The title is weird. How about changing it to feat: apply Ostracon's changes that replace StakingPower with VotingPower and VotingPower with VotingWeight?

@zemyblue
Copy link
Member Author

The title is weird. How about changing it to feat: apply Ostracon's changes that replace StakingPower with VotingPower and VotingPower with VotingWeight?

I don't know what is different. Do you mean removing backquote in title?

@dudong2
Copy link
Contributor

dudong2 commented Jul 29, 2022

The title is weird. How about changing it to feat: apply Ostracon's changes that replace StakingPower with VotingPower and VotingPower with VotingWeight?

I don't know what is different. Do you mean removing backquote in title?

StakingPower with VotingPower is duplicated.

@zemyblue zemyblue changed the title feat: apply Ostracon's changes that replace StakingPower with VotingPower and StakingPower with VotingPower. feat: apply Ostracon's changes that replace StakingPower with VotingPower and VotingPower with VotingWeight. Jul 29, 2022
@zemyblue
Copy link
Member Author

The title is weird. How about changing it to feat: apply Ostracon's changes that replace StakingPower with VotingPower and VotingPower with VotingWeight?

I don't know what is different. Do you mean removing backquote in title?

StakingPower with VotingPower is duplicated.

Oh. I understand. Thank you.

tnasu
tnasu approved these changes Jul 29, 2022
View reviewed changes
Copy link
Member

@tnasu tnasu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zemyblue zemyblue merged commit a911511 into Finschia:main Jul 29, 2022
dudong2 added a commit to dudong2/lbm-sdk that referenced this pull request Aug 1, 2022
@zemyblue @dudong2
feat: apply Ostracon's changes that replace StakingPower with `Voti…
ccdb52a 
…ngPower` and `VotingPower` with `VotingWeight`. (Finschia#614)

* feat: apply the ostracon's change that replace `StakingPower` with `VotingPower` and `StakingPower` with `VotingWeight`.
Finschia/ostracon#449

Signed-off-by: zemyblue <[email protected]>

* docs: update swagger.yaml and statik.go

Signed-off-by: zemyblue <[email protected]>

* docs: update changelog

Signed-off-by: zemyblue <[email protected]>

* chore: update latest changes of ostracon.

Signed-off-by: zemyblue <[email protected]>

* chore: update latest changes of ostracon.

Signed-off-by: zemyblue <[email protected]>

* Update third_party/proto/ostracon/types/evidence.proto

Co-authored-by: Sujong Lee <[email protected]>

Co-authored-by: Sujong Lee <[email protected]>
@zemyblue zemyblue deleted the ostracon_voting_power branch October 19, 2022 02:52
@zemyblue zemyblue mentioned this pull request Oct 27, 2022
Merged
5 tasks
@zemyblue zemyblue mentioned this pull request Nov 28, 2022
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dudong2 dudong2 dudong2 approved these changes

@tnasu tnasu tnasu approved these changes

@torao torao torao approved these changes

@0Tech 0Tech Awaiting requested review from 0Tech 0Tech is a code owner

Assignees

@zemyblue zemyblue

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zemyblue @dudong2 @torao @tnasu