Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: revert gRPC block height header. #607

Merged
merged 2 commits into from
Jul 26, 2022

Conversation

zemyblue
Copy link
Member

@zemyblue zemyblue commented Jul 22, 2022

Description

Revert gRPC block height header.
x-lbm-block-height -> x-cosmos-block-height

Motivation and context

I think no need to keep the x-lbm-block-height.

How has this been tested?

Screenshots (if appropriate):

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

@zemyblue zemyblue self-assigned this Jul 22, 2022
Signed-off-by: zemyblue <[email protected]>
@zemyblue zemyblue requested review from 0Tech, dudong2, tnasu and torao July 22, 2022 10:32
@codecov
Copy link

codecov bot commented Jul 22, 2022

Codecov Report

Merging #607 (05d213f) into main (1bc3aac) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #607   +/-   ##
=======================================
  Coverage   60.60%   60.60%           
=======================================
  Files         814      814           
  Lines       94798    94798           
=======================================
  Hits        57448    57448           
  Misses      34097    34097           
  Partials     3253     3253           

@zemyblue zemyblue merged commit 7cdbce7 into Finschia:main Jul 26, 2022
@zemyblue zemyblue deleted the x-cosmos-block-header branch August 8, 2022 08:30
@zemyblue zemyblue mentioned this pull request Oct 27, 2022
5 tasks
@zemyblue zemyblue mentioned this pull request Nov 28, 2022
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants