Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: replace line/iavl, line/tm-db with cosmos/iavl, tendermint/tm-db #605

Merged
merged 9 commits into from
Jul 26, 2022

Conversation

dudong2
Copy link
Contributor

@dudong2 dudong2 commented Jul 21, 2022

Description

remove iavl cache and iavl cache manager
replace line/iavl and line/tm-db to cosmos/iavl and tendermint/tm-db
closes: #581

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

@dudong2 dudong2 self-assigned this Jul 21, 2022
@dudong2 dudong2 changed the title Dudong2/perf/remove line iavl perf: replace line/iavl -> cosmos/iavl, line/tm-db -> tendermint/tm-db Jul 21, 2022
@dudong2 dudong2 changed the title perf: replace line/iavl -> cosmos/iavl, line/tm-db -> tendermint/tm-db perf: replace line/iavl -> cosmos/iavl Jul 21, 2022
@codecov
Copy link

codecov bot commented Jul 21, 2022

Codecov Report

Merging #605 (cecebfe) into main (7cdbce7) will increase coverage by 0.06%.
The diff coverage is 68.18%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #605      +/-   ##
==========================================
+ Coverage   59.61%   59.67%   +0.06%     
==========================================
  Files         814      811       -3     
  Lines       95454    95245     -209     
==========================================
- Hits        56901    56834      -67     
+ Misses      35000    34833     -167     
- Partials     3553     3578      +25     
Impacted Files Coverage Δ
baseapp/abci.go 61.64% <ø> (-0.18%) ⬇️
baseapp/baseapp.go 80.04% <ø> (ø)
simapp/app.go 87.82% <ø> (ø)
store/cachekv/mergeiterator.go 79.86% <0.00%> (-8.95%) ⬇️
store/cachemulti/store.go 9.52% <ø> (ø)
store/dbadapter/store.go 100.00% <ø> (ø)
store/iavl/tree.go 89.65% <ø> (ø)
store/types/store.go 56.25% <ø> (ø)
testutil/context.go 0.00% <0.00%> (ø)
types/utils.go 66.66% <0.00%> (ø)
... and 27 more

@dudong2 dudong2 changed the title perf: replace line/iavl -> cosmos/iavl perf: replace line/iavl, line/tm-db with cosmos/iavl, tendermint/tm-db Jul 21, 2022
@dudong2 dudong2 marked this pull request as ready for review July 21, 2022 14:59
@dudong2 dudong2 requested review from 0Tech, zemyblue and torao July 21, 2022 23:21
CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@0Tech 0Tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dudong2 dudong2 merged commit 7b240f0 into Finschia:main Jul 26, 2022
@dudong2 dudong2 deleted the dudong2/perf/remove-line-iavl branch July 26, 2022 05:17
@zemyblue zemyblue mentioned this pull request Oct 27, 2022
5 tasks
@zemyblue zemyblue mentioned this pull request Nov 28, 2022
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Evaluation of Datastore Caching changes
4 participants